fix: remove internal alert stack and use the platform AlertStack #2796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-2796--dhis2-maps.netlify.app |
jenniferarnesen
force-pushed
the
fix/duplicated-alert-stack
branch
from
6340bb4
to
4e167ed
Compare
jenniferarnesen
force-pushed
the
fix/duplicated-alert-stack
branch
from
66bf261
to
0d86b4f
Compare
…p into fix/duplicated-alert-stack
BRaimbault
requested changes
Jul 26, 2024
BRaimbault
approved these changes
Jul 30, 2024
dhis2-bot
added a commit
that referenced
this pull request
Jul 31, 2024
## [100.5.9](v100.5.8...v100.5.9) (2024-07-31) ### Bug Fixes * loader alert messages were being duplicated ([#2796](#2796)) ([69776ad](69776ad))
|
🎉 This PR is included in version 100.5.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://dhis2.atlassian.net/browse/DHIS2-15438
The alerts were duplicated because there was both an internal alert stack/bar system as well as the built in one from app-runtime. Solution was to remove the internal alert stack/bar. This meant that the alerts coming from the layer loaders had to be refactored so that loader alerts are no longer are added to redux. Instead the component LayerLoaders use the app-runtime hook (useAlert).
Other changes:
skipPluginLogic: truehas been added to d2.config.js because of the cli-app-scripts upgrade. Previously we had set a resolution for the dependency to workaround this bug: https://dhis2.atlassian.net/browse/DHIS2-16916. Now, we can remove the resolution as long as we include this config.Before (see video in Jira issue)
After:
https://github.com/dhis2/maps-app/assets/6113918/309a29c4-e467-47a6-88e3-0e63ef5534b4
For reference, these are all the layer messages (where majority of changes are):
Earth Engine alerts:
Event Layer alerts:
Facility layer alerts
OrgUnit Layer alerts
Thematic Layer alerts
TE Layer alerts
