Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve support for right-to-left languages in Data Visualiser #3073

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

kabaros
Copy link
Collaborator

@kabaros kabaros commented May 31, 2024

Implements DHIS2-16778

Key features

  1. Use logical CSS properties instead of physical properties throughout the project (done automatically with a tool)
  2. Update the cli-style to a version that supports checking logical properties (and automatically converting physical to logical properties)

Description

This PR implements better support for right-to-left languages in the app, by leveraging the use of logical CSS properties that are independent of language direction, rather than physical properties (i.e. *-start instead of -left and *-end instead *-right). Logical properties are widely supported now and they should become the default way for layout going-forward to ensure that we support RTL languages without extra development burden (which will be enforced by d2 style).

Although the change set is big. It's mostly done automatically using d2 style apply css which under the hood uses stylelint to enforce and apply the rules.

The better support for RTL builds on top of previous work done in the platform, namely:

Testing

  • The main test here should be that the app in English (or any LTR language) should look exactly as before, after these changes.
  • Test on an environment set to Arabic (or any other RTL language) to confirm it looks as expected for an RTL user.

Screenshots

Before After
image image

Copy link

cypress bot commented May 31, 2024

Passing run #2868 ↗︎

0 742 2 0 Flakiness 0

Details:

fix: non-existing AO blocks new AOs from being created (DHIS2-13167) (#3056)
Project: Data Visualizer App Commit: b9b5beb26c
Status: Passed Duration: 09:51 💡
Started: May 31, 2024 12:06 PM Ended: May 31, 2024 12:15 PM

Review all test suite changes for PR #3073 ↗︎

@kabaros kabaros force-pushed the DHIS2-16778/visualiser-rtl-support branch from 699ef59 to 9091369 Compare May 31, 2024 19:13
@kabaros kabaros force-pushed the DHIS2-16778/visualiser-rtl-support branch from 9091369 to 572b12d Compare June 1, 2024 19:14
@dhis2-bot
Copy link
Contributor

dhis2-bot commented Jun 1, 2024

@dhis2-bot dhis2-bot temporarily deployed to netlify June 1, 2024 19:16 Inactive
@kabaros kabaros force-pushed the DHIS2-16778/visualiser-rtl-support branch from 572b12d to da932a3 Compare June 3, 2024 09:34
@kabaros kabaros force-pushed the DHIS2-16778/visualiser-rtl-support branch from da932a3 to c16e61d Compare June 3, 2024 09:35
@dhis2-bot dhis2-bot temporarily deployed to netlify June 3, 2024 09:44 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify June 3, 2024 10:10 Inactive
Copy link

cypress bot commented Jun 3, 2024

Passing run #2875 ↗︎

0 745 2 0 Flakiness 0

Details:

Merge 7c1fffb into 34479f1...
Project: Data Visualizer App Commit: bf724c147c ℹ️
Status: Passed Duration: 09:05 💡
Started: Jun 3, 2024 12:52 PM Ended: Jun 3, 2024 1:01 PM

Review all test suite changes for PR #3073 ↗︎

@kabaros kabaros marked this pull request as ready for review June 3, 2024 12:35
@kabaros kabaros requested a review from a team June 3, 2024 14:07
@jenniferarnesen jenniferarnesen changed the base branch from dev to master June 21, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants