-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove d2 #3023
Draft
edoardo
wants to merge
7
commits into
master
Choose a base branch
from
fix/remove-d2-v2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
fix: remove d2 #3023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🚀 Deployed on https://pr-3023--dhis2-data-visualizer.netlify.app |
5b66293
to
823a99b
Compare
The confirm screen when leaving the page didn't work with functional components.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-XXXX
Key features
d2
entirelyDescription
This branch has changes to remove the need for
d2
.There is still one place where
d2
is needed and we don't have an alternative at the moment, the user data store.TODO
d2
be tested in Cypress and what in unit tests
ALL
, do we really need theisSuperuser
flag?Known issues
d2
as it's using some classes defined in that package.settings
. Fixed here.Screenshots
Not very meaningful but this is the app running on this branch:
![Screenshot 2022-07-21 at 15 16 34](https://user-images.githubusercontent.com/150978/180222836-34ae5926-309c-4b86-8365-2232696f760e.png)