-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove d2 #2125
Draft
edoardo
wants to merge
36
commits into
master
Choose a base branch
from
fix/remove-d2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
fix: remove d2 #2125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🚀 Deployed on https://pr-2125--dhis2-data-visualizer.netlify.app |
9ff75c5
to
1e1872e
Compare
🚀 Deployed on https://pr-2125--dhis2-data-visualizer.netlify.app |
b9417b2
to
c71d82a
Compare
c71d82a
to
07e91d8
Compare
07e91d8
to
35ff6db
Compare
4a26ffb
to
05f3c9b
Compare
This is to avoid the double Redux store issue. The wrapper where the Redux store is created cannot use effects that can cause the component to rerender as this will cause a second Redux store to be created.
This code might be needed later after more refactoring, so leaving it commented for now.
The new interpretation modal is used now.
* Remove uiLocale prop as it's not used. * Fix filtering of authorities to set the superuser flag * Adjusted tests
This eventually can be skipped once all components are converted into functional components and the hooks can be used everywhere.
Only compute it when the selector is used (apparently never).
The coverage is provided by Cypress for opening various AOs and the currentAnalyticalObject
05f3c9b
to
2840c27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-XXXX
Key features
d2
entirelyDescription
This branch has changes to remove the need for
d2
.There is still one place where
d2
is needed and we don't have an alternative at the moment, the user data store.TODO
d2
be tested in Cypress and what in unit tests
ALL
, do we really need theisSuperuser
flag?Known issues
d2
as it's using some classes defined in that package.settings
. Fixed here.Screenshots
Not very meaningful but this is the app running on this branch:
![Screenshot 2022-07-21 at 15 16 34](https://user-images.githubusercontent.com/150978/180222836-34ae5926-309c-4b86-8365-2232696f760e.png)