#453: Add new data validation: ListFormulaDataValidation. #454
Conversation
Add the possibility to set global visibility to range when a named range is added.
|
@meiMingle @rzymek can you check the pull request and if you think the change makes sense, merge it into master? |
| public void write(Writer w) throws IOException { | ||
| w | ||
| .append("<dataValidation sqref=\"") | ||
| .append(range.toString()) |
There was a problem hiding this comment.
If I try to append the range without "toString", an error is return
| */ | ||
| public Range setGlobalVisibility(boolean globalVisibility) { | ||
| this.globalVisibility = globalVisibility; | ||
| return this; |
There was a problem hiding this comment.
other setters return void. returning this here seems inconsistent
| @@ -44,6 +44,11 @@ public class Range implements Ref { | |||
| */ | |||
| private final int right; | |||
|
|
|||
| /** | |||
| * Check about the Range visibility when a named range is added. | |||
There was a problem hiding this comment.
I find this comment confusing. Doesn't seem to turn on any "Check", but rather control the scope of this range (right?)
|
@rzymek thank you for your comments and your time. |
|
Please @rzymek, can you close the pull request if all is ok? Otherwise can you tell me what needs to be fix to complete the pull request? |
Fixing the issue 453:: a new data validation is added:
ListFormulaDataValidation.This
DataValidationallow to create a data validation withlisttype and with aformulavalue (to referrer a list, for example withINDIRECTformula).In addition, it is possibility to set global visibility to a range when a named range is added.