Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReadableWorkbook constructor with File and ReadingOptions #191

Closed
AstrorEnales opened this issue Jan 17, 2022 · 1 comment
Closed

ReadableWorkbook constructor with File and ReadingOptions #191

AstrorEnales opened this issue Jan 17, 2022 · 1 comment

Comments

@AstrorEnales
Copy link

First, thanks for this project! It solved the memory and speed issues i had with apache poi.

As the InputStream constructor copies all bytes to memory, i would be happy to use the File constructor of ReadableWorkbook, however, i also need the ReadingOptions to read cell data formats. So it would be wonderful, if you could add a constructor overload with these two parameters:
public ReadableWorkbook(File inputFile, ReadingOptions readingOptions) throws IOException { this(OPCPackage.open(inputFile, readingOptions.isWithCellFormat()), readingOptions); }

As it's only three lines of code, i refrained from creating a whole fork and pull request.

@ochedru
Copy link
Collaborator

ochedru commented Jan 17, 2022

Thank you for your feedback. I'll do the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants