Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add deploy wallet subcommand to identity #1414

Merged
merged 27 commits into from
Feb 18, 2021
Merged

Conversation

p-shahi
Copy link
Contributor

@p-shahi p-shahi commented Feb 16, 2021

fixes https://github.com/dfinity/dx-triage/issues/50

dfx identity deploy-wallet --help
dfx-identity-deploy-wallet
Installs the wallet WASM to the provided canister id

USAGE:
    dfx identity deploy-wallet <canister-id>

ARGS:
    <canister-id>    The ID of the canister where the wallet WASM will be deployed

FLAGS:
    -h, --help       Prints help information
    -V, --version    Prints version information

Base automatically changed from pshahi/wallet-wasm-did to master February 16, 2021 01:15
@p-shahi p-shahi marked this pull request as ready for review February 17, 2021 02:02
@p-shahi p-shahi requested a review from hansl February 17, 2021 02:03

== DFX

- feat: add deploy wallet subcommand to identity #1414
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lsgunnlsgunn fyi for the docs

Copy link
Contributor

@hansl hansl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I would like @ericswanson-dfinity to review as well. thanks!

@mergify mergify bot merged commit b704432 into master Feb 18, 2021
@mergify mergify bot deleted the pshahi/deploy_wallet branch February 18, 2021 23:26
dfinity-bot added a commit that referenced this pull request Sep 8, 2022
mergify bot pushed a commit that referenced this pull request Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants