add ThemeToggleButton, tests and doc

[coskucinkilic]

Motivation

Add new ThemeToggleButton component

Changes

ThemeToggleButton component added to repo
Tests for ThemeToggleButton added to spec file
ThemeToggleButton is added to showcase
--icon-color variable added to IconDarkMode and IconLightMode
New --sidebar-icon variable has been added to themes

Screenshots

[peterpeterparker]

Thanks for the PR. How does it look in the gix-cmp showcase? If it needs adaptation, are you going to provide those in another PR? (It’s probably best to do it in two separate PRs indeed.)

[dskloetd]

Does this button work as a drop-in replacement of the toggle even if we don't move the component to a different place in the page?
If not, I think it would be better to introduce a new component instead of changing the existing one.

[peterpeterparker]

drop-in replacement

Note that I left comments assuming it was a drop-in replacement (that the community dev using the lib should also adopt).
Agree on introducing a new component if it isn't.

[coskucinkilic]

Waiting for an answer from Artem

[coskucinkilic]

Artem told me this is a replacement, please provide feedback accordingly

[dskloetd]

Artem told me this is a replacement, please provide feedback accordingly

I'm confused by this. Can you show me how this looks in the account menu instead of the current theme switcher in the account menu?

[coskucinkilic]

@dskloetd here you go:

[dskloetd]

Thanks!

[peterpeterparker]

Look weird in the context menu but, that's a question above my pay grade.

Can you also share the screenshots regarding my earlier question as well?

[dskloetd]

@peterpeterparker is talking about this: https://github.com/dfinity/gix-components?tab=readme-ov-file#documentation--showcase

If you npm run dev it shows a page where you can see all the components in action.

[coskucinkilic]

@peterpeterparker


@dskloetd there are couple of updates after your approval, could you please take a quick look?

[peterpeterparker]

Thanks. In the context menu it's fine as well?

[coskucinkilic]

After talking with Artem again, he said we will most probably don't use it but as people are aready using it outside of NNS let's keep both toggle and the button.

I will be moving some files around, will leave the context menu as is with ThemeToggle

[peterpeterparker]

Can you edit the description of the PR, I think it does not match anymore given that you are providing a new component.

[peterpeterparker]

LGTM, thx

[dskloetd]

Not important at all, but I was wondering if it makes sense to put the switch and the button on the same show-case page so you can see them side by side and know the other one also exists if you look at one.

[peterpeterparker]

Makes sense. I actually started writing a review comment when I approved the PR about referencing the components (adding links from one to the other), but ultimately did not provide the feedback as I felt I had already been picky enough.

@coskucinkilic WDYT?