feat: Argo listing change #5768

kartik-579 · 2024-08-30T07:58:34Z

Description

Checklist:

The title of the PR states what changed and the related issues number (used for the release note).
Does this PR requires documentation updates?
I've updated documentation as required by this PR.
I have performed a self-review of my own code.
I have commented my code, particularly in hard-to-understand areas.
I have tested it for all user roles.
I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

* ValidateEncodedDataByDecoding in case add or update secret * wire fix from main * minor refactor * comment

…ault_value text from varchar255 (#5701) * script for pipelineStageStepVariable, making input value and default_value text from varchar255 * erro log fix

* added the ea apps entry app table * resolved the ea mode multiple rows error during configuration of app * modified the ea dockerfile in ca-certificates cmd * uncommented the code and left the ea helm app making way untouched * remodified the dockerfile as previous state * modified the docker file ea mode * dockerfile exit code 100 due to ap install alternative in ea mode dockerfile * execute make after main merge * modified changes in dockerfile ea mode * resolved comments after first level review

This reverts commit 3e31f49.

…andle runtime params validation (#5712) * SkipCiBuildCachePushPull code incorporated with minor refac in handle runtime params validation * minor refactor * minor refactor

* Edit Deployment Chart Schema * Fixes * PM + CO Feedback Incorporated

* Edit Deployment Chart Schema * Fixes * PM + CO Feedback Incorporated * Redirected Old Entry

* added docs for air-gapped-installation * added all the images in 7.0.0 * modified yq command in the docs * added an entry in summary.md * added installation commands * modified statements * modified variable name * added steps to navigation * added the latest oss chart images * added a note for docker * Added Intro + Proofreading + Structuring * Other fixes * Lang fix * added docs for ea-mode only * modified lang * Update install-devtron-in-airgapped-environment.md Changed h3 header to fit the ToC on the RHS * added changes * modified changes --------- Co-authored-by: Badal Kumar Prusty <badalkumar@Badals-MacBook-Pro.local> Co-authored-by: ashokdevtron <141001279+ashokdevtron@users.noreply.github.com>

* env description handling added * license handling

* added config sql script (#5681) * feat: CVE severity categorisation and scan result listing API enhancements (#5617) * feat: add support for app and env sorting in scan list api and add medium, high and unknown severity support * fix: query fix for appName sort or envName sort * fix: sql script number change * fix: minor changes * fix: review fix * fix: remove dml on cve_store and handle it in code handling this versioning * fix: review comments * fix: update script numbers * fix: minor fix * feat: casbin deny policy sql scripts (#5677) * system controller scripts * script additions * sql cript update * sql script number chnage * feat: Config diff phase 2 oss (#5488) * story(configDiffView) : open api spec * story(configDiffView) : open api spec updated * story(configDiffView) : open api spec updated for error state * story(configDiffView) : WIP * story(configDiffView) : WIP "some code changed" * story(configDiffView) : support for names added * story(configDiffView) : iota removed * story(configDiffView) : pg no rows handled * story(configDiffView) : spelling check * story(configDiffView) : code review comment resolved * story(configDiffView) : env id added * story(configDiffView) : intersection added * story(configDiffView) : comments removed * story(configDiffView) : code review comment resolved * story(configDiffView) : comment removed * story(configDiffView) : CMCSNames DTO moved * story(configDiffView) : null case handled * story(configDiffView) : logger added * story(configDiffView) : code refactored * story(configDiffView) : code refactored v2 * story(configDiffView) : spec updated * story(configDiffView) : code refactored * story(configDiffView) : config names * main sync * overridden and global flag introduced in config diff autocomplete api * ent sync * get config data in resthandler * new api for showing all config data in config/data :- Service func -> GetAllConfigData * using a single key instead of global and overridden key in config/autocomplete api * ConfigState made string instead of int * not sending inheriting in case base config * code review comment incorporation * ent sync * code review comment incorp -1 * code review comment incorp -2 * code review comment incorp -3 * small fix in plugin * migration number changes (#5692) * main sync * minor fix * refrain from checkin autoscalingCheckBeforeTrigger for virt clus (#5696) * fix: Decode secret fix on add update oss (#5695) * ValidateEncodedDataByDecoding in case add or update secret * wire fix from main * minor refactor * comment * saving pco concurrency case handled (#5688) * fix: script for pipelineStageStepVariable, making input value and default_value text from varchar255 (#5701) * script for pipelineStageStepVariable, making input value and default_value text from varchar255 * erro log fix * scipt number change --------- Co-authored-by: adi6859 <aditya.ar1909@gmail.com> Co-authored-by: Vikram Singh <vikram@devtron.ai> * fix: Helm apps entries in Ea mode (#5652) * added the ea apps entry app table * resolved the ea mode multiple rows error during configuration of app * modified the ea dockerfile in ca-certificates cmd * uncommented the code and left the ea helm app making way untouched * remodified the dockerfile as previous state * modified the docker file ea mode * dockerfile exit code 100 due to ap install alternative in ea mode dockerfile * execute make after main merge * modified changes in dockerfile ea mode * resolved comments after first level review * executed make after merging with develop branch * feat: refactoring deployment app name usage (#5702) * removing hard coded deployment app name * removing %s-%s usage * wip: query change for enterprise * wip * wip * wip * adding release mode in deployment config * wip: release changes * left join on pco and artifact * handling empty release mode - backward compatibility * fixing panic * migration number changes (#5692) * refrain from checkin autoscalingCheckBeforeTrigger for virt clus (#5696) * fix: Decode secret fix on add update oss (#5695) * ValidateEncodedDataByDecoding in case add or update secret * wire fix from main * minor refactor * comment * saving pco concurrency case handled (#5688) * migration updated * main merge and migration script updated * wip * review changes * fix sql no --------- Co-authored-by: Prakash <prakash.kumar@devtron.ai> * migration syn with ent (#5719) * fix: group image vulnerabilities by base/os image (#5680) * feat: add support for app and env sorting in scan list api and add medium, high and unknown severity support * fix: query fix for appName sort or envName sort * fix: sql script number change * fix: minor changes * fix: review fix * fix: remove dml on cve_store and handle it in code handling this versioning * fix: review comments * feat: storing target,class and type values in imageScanExecutionResults * feat: add sql script * feat: add sql script * fix: add new columns * fix: update script numbers * fix: correct down script * fix: minor fix * chore: script number update * fix: remove sql script (#5727) * Revert "fix: Helm apps entries in Ea mode (#5652)" (#5733) This reverts commit f1aa1fc. * chore: custom argo-workflow dependency (#5731) * bumped github.com/argoproj/argo-workflows/v3 v3.5.10 => github.com/devtron-labs/argo-workflows/v3 v3.5.10 * migration number changes (#5692) * refrain from checkin autoscalingCheckBeforeTrigger for virt clus (#5696) * fix: Decode secret fix on add update oss (#5695) * ValidateEncodedDataByDecoding in case add or update secret * wire fix from main * minor refactor * comment * saving pco concurrency case handled (#5688) * fix: script for pipelineStageStepVariable, making input value and default_value text from varchar255 (#5701) * script for pipelineStageStepVariable, making input value and default_value text from varchar255 * erro log fix * fix: ea fixes for helm app (#5708) * added the ea apps entry app table * resolved the ea mode multiple rows error during configuration of app * modified the ea dockerfile in ca-certificates cmd * uncommented the code and left the ea helm app making way untouched * remodified the dockerfile as previous state * modified the docker file ea mode * dockerfile exit code 100 due to ap install alternative in ea mode dockerfile * execute make after main merge * modified changes in dockerfile ea mode * resolved comments after first level review * Revert "fix: ea fixes for helm app (#5708)" (#5713) This reverts commit 3e31f49. * fix: SkipCiBuildCachePushPull code incorporated with minor refac in handle runtime params validation (#5712) * SkipCiBuildCachePushPull code incorporated with minor refac in handle runtime params validation * minor refactor * minor refactor * migration syn with ent (#5718) * reverted main branch changes * reverted main branch changes --------- Co-authored-by: Prakash <prakash.kumar@devtron.ai> Co-authored-by: Rajeev Ranjan <90333766+RajeevRanjan27@users.noreply.github.com> Co-authored-by: prakhar katiyar <39842461+prkhrkat@users.noreply.github.com> * chore: fix go.sum file (#5734) * misc: Main sync develop (#5737) * migration number changes (#5692) * refrain from checkin autoscalingCheckBeforeTrigger for virt clus (#5696) * fix: Decode secret fix on add update oss (#5695) * ValidateEncodedDataByDecoding in case add or update secret * wire fix from main * minor refactor * comment * saving pco concurrency case handled (#5688) * fix: script for pipelineStageStepVariable, making input value and default_value text from varchar255 (#5701) * script for pipelineStageStepVariable, making input value and default_value text from varchar255 * erro log fix * fix: ea fixes for helm app (#5708) * added the ea apps entry app table * resolved the ea mode multiple rows error during configuration of app * modified the ea dockerfile in ca-certificates cmd * uncommented the code and left the ea helm app making way untouched * remodified the dockerfile as previous state * modified the docker file ea mode * dockerfile exit code 100 due to ap install alternative in ea mode dockerfile * execute make after main merge * modified changes in dockerfile ea mode * resolved comments after first level review * Revert "fix: ea fixes for helm app (#5708)" (#5713) This reverts commit 3e31f49. * fix: SkipCiBuildCachePushPull code incorporated with minor refac in handle runtime params validation (#5712) * SkipCiBuildCachePushPull code incorporated with minor refac in handle runtime params validation * minor refactor * minor refactor * migration syn with ent (#5718) --------- Co-authored-by: Prakash <prakash.kumar@devtron.ai> Co-authored-by: Rajeev Ranjan <90333766+RajeevRanjan27@users.noreply.github.com> Co-authored-by: prakhar katiyar <39842461+prkhrkat@users.noreply.github.com> * fix: Validate config cm cs (#5750) * validateConfigRequest before CMGlobalAddUpdate and CSGlobalAddUpdate * checkIfConfigDataAlreadyExist --------- Co-authored-by: ayu-devtron <167413063+ayu-devtron@users.noreply.github.com> Co-authored-by: Vikram Singh <vikram@devtron.ai> Co-authored-by: Gireesh Naidu <111440205+gireesh-naidu@users.noreply.github.com> Co-authored-by: Shivam Nagar <124123645+Shivam-nagar23@users.noreply.github.com> Co-authored-by: Prakash <prakash.kumar@devtron.ai> Co-authored-by: adi6859 <aditya.ar1909@gmail.com> Co-authored-by: Rajeev Ranjan <90333766+RajeevRanjan27@users.noreply.github.com> Co-authored-by: iamayushm <32041961+iamayushm@users.noreply.github.com> Co-authored-by: prakhar katiyar <39842461+prkhrkat@users.noreply.github.com> Co-authored-by: Asutosh Das <asutosh2000ad@gmail.com> Co-authored-by: Vikram <73224103+vikramdevtron@users.noreply.github.com> Co-authored-by: Prakarsh <71125043+prakarsh-dt@users.noreply.github.com>

* Update prerequisites of code-scan * Hyperlinked the Vulnerability scanning doc --------- Co-authored-by: ashokdevtron <141001279+ashokdevtron@users.noreply.github.com>

* Added support for basic auth in servicemonitor * Added support for namespace selector and custom matchLabels * Fixed indentations

* bitnami_chart_fix * Rename 278_bitnami_chart_fix.down.sql to 282_bitnami_chart_fix.down.sql * Rename 278_bitnami_chart_fix.up.sql to 282_bitnami_chart_fix.up.sql --------- Co-authored-by: Pawan Mehta <117346502+pawan-mehta-dt@users.noreply.github.com>

* doc for cosign plugin * edits in task name * updates in intro and other fixes. * Attached link to Cosign GitHub repo * Hyperlink fixes --------- Co-authored-by: ashokdevtron <141001279+ashokdevtron@users.noreply.github.com>

* admin check fix in config draft * minor fix

* doc for * edits in task name * spelling correction * Updated password --------- Co-authored-by: ashokdevtron <141001279+ashokdevtron@users.noreply.github.com>

* devtron-cd-trigger plugin doc * minor update * Proofreading done * Update devtron-cd-trigger.md * Removed unwanted phrase * Changed wording * Changed plurality * Updated devtron token --------- Co-authored-by: ashokdevtron <141001279+ashokdevtron@users.noreply.github.com>

* vulnerability scanning plugin doc * summary.md added

* Docs of Jira Plugins - Validator and Updater * Added Index Links * Additional Proofreading

…onm method

* added commands emable ingress during helm installation * modified commands * improved statement * removed unrequired lines --------- Co-authored-by: Badal Kumar Prusty <badalkumar@Badals-MacBook-Pro.local>

Co-authored-by: Badal Kumar Prusty <badalkumar@Badals-MacBook-Pro.local>

Co-authored-by: Nishant <58689354+nishant-d@users.noreply.github.com>

* modifying route * modified the anchorlink --------- Co-authored-by: Badal Kumar Prusty <badalkumar@Badals-MacBook-Pro.local>

* upgraded to /argo-cd/v2 v2.9.21 * argocd vendor files added * sync with common-lib

* app found using display or app name * single query optimization * display name handling for new apps --------- Co-authored-by: kartik-579 <kartik@devtron.ai>

gitguardian · 2024-09-09T06:56:14Z

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
10220829	Triggered	Generic High Entropy Secret	`d816dee`	devtron-images.txt.source	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secret safely. Learn here the best practices.
Revoke and rotate this secret.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

sonarcloud · 2024-09-09T07:51:45Z

Quality Gate failed

Failed conditions
9.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

prakash100198 and others added 30 commits August 15, 2024 23:23

migration number changes (#5692)

779e913

refrain from checkin autoscalingCheckBeforeTrigger for virt clus (#5696)

4f04d6b

fix: Decode secret fix on add update oss (#5695)

2e58e77

* ValidateEncodedDataByDecoding in case add or update secret * wire fix from main * minor refactor * comment

saving pco concurrency case handled (#5688)

bf23515

fix: script for pipelineStageStepVariable, making input value and def…

694831c

…ault_value text from varchar255 (#5701) * script for pipelineStageStepVariable, making input value and default_value text from varchar255 * erro log fix

Revert "fix: ea fixes for helm app (#5708)" (#5713)

8de88d7

This reverts commit 3e31f49.

fix: SkipCiBuildCachePushPull code incorporated with minor refac in h…

378c2d9

…andle runtime params validation (#5712) * SkipCiBuildCachePushPull code incorporated with minor refac in handle runtime params validation * minor refactor * minor refactor

migration syn with ent (#5718)

827608f

doc: Edit Deployment Chart Schema (#5735)

5f43eb2

* Edit Deployment Chart Schema * Fixes * PM + CO Feedback Incorporated

doc: Redirection of old entry in gitbook.yaml (#5738)

16d01d6

* Edit Deployment Chart Schema * Fixes * PM + CO Feedback Incorporated * Redirected Old Entry

feat: Env description handling (#5744)

26784d5

* env description handling added * license handling

doc: Update prerequisites of code-scan (#5625)

8a61bac

* Update prerequisites of code-scan * Hyperlinked the Vulnerability scanning doc --------- Co-authored-by: ashokdevtron <141001279+ashokdevtron@users.noreply.github.com>

fix: ci patch rbac for branch update (#5759)

6da544f

feat: Added basic auth support for servicemonitor (#5761)

09946c2

* Added support for basic auth in servicemonitor * Added support for namespace selector and custom matchLabels * Fixed indentations

doc: Cosign plugin doc (#5665)

7ee4a32

* doc for cosign plugin * edits in task name * updates in intro and other fixes. * Attached link to Cosign GitHub repo * Hyperlink fixes --------- Co-authored-by: ashokdevtron <141001279+ashokdevtron@users.noreply.github.com>

fix: check rbac on env if envName is present (#5765)

99d10f5

* admin check fix in config draft * minor fix

doc: CraneCopy plugin doc (#5658)

f1a50b1

* doc for * edits in task name * spelling correction * Updated password --------- Co-authored-by: ashokdevtron <141001279+ashokdevtron@users.noreply.github.com>

wip

74ae3e4

wip

0f90450

wip

ef838ae

wip

88e0898

wip

974e866

wip

8a1f5df

wip

df34a81

wip

7200791

bhushan-nemade-dt and others added 14 commits September 3, 2024 10:48

doc: Vulnerability Scanning Plugin doc (#5722)

ba02845

* vulnerability scanning plugin doc * summary.md added

docs: Jira plugins doc (Validator + Updater) (#5709)

02f4a1b

* Docs of Jira Plugins - Validator and Updater * Added Index Links * Additional Proofreading

add basic auth and tls for sm (#5789)

a6a2ae2

Merge branch 'main' into argo-listing-change

0613064

reverted common lib change

6eb0cc1

updated handling for getting restConfig through custom transport comm…

3e68996

…onm method

docs: added commands enable ingress during helm installation (#5794)

654ba93

* added commands emable ingress during helm installation * modified commands * improved statement * removed unrequired lines --------- Co-authored-by: Badal Kumar Prusty <badalkumar@Badals-MacBook-Pro.local>

Revamped + Restructured Ingress Setup Doc (#5798)

0e16daf

modifying route (#5799)

d4bd272

Co-authored-by: Badal Kumar Prusty <badalkumar@Badals-MacBook-Pro.local>

fix: cron status update refactoring (#5790)

43ba232

Co-authored-by: Nishant <58689354+nishant-d@users.noreply.github.com>

docs: modified the anchorlink in ingress.md (#5800)

be9d553

* modifying route * modified the anchorlink --------- Co-authored-by: Badal Kumar Prusty <badalkumar@Badals-MacBook-Pro.local>

query param split (#5801)

1e0af22

fix: upgraded to /argo-cd/v2 v2.9.21 (#5758)

8f92d3f

* upgraded to /argo-cd/v2 v2.9.21 * argocd vendor files added * sync with common-lib

fix: Ea rbac fixes (#5813)

bd51187

* app found using display or app name * single query optimization * display name handling for new apps --------- Co-authored-by: kartik-579 <kartik@devtron.ai>

kartik-579 changed the base branch from main to develop September 9, 2024 06:56

kartik-579 requested review from pawan-mehta-dt, uxarya-d and ashokdevtron as code owners September 9, 2024 06:56

kartik-579 changed the title ~~wip:Argo listing change~~ feat :Argo listing change Sep 9, 2024

github-actions bot added PR:Ready-to-Review and removed PR:Issue-verification-failed labels Sep 9, 2024

kartik-579 and others added 3 commits September 9, 2024 12:27

Merge branch 'main' into argo-listing-change

71facbe

Merge branch 'develop' into argo-listing-change

0ab6af4

Merge branch 'develop' into argo-listing-change

7f80394

kartik-579 changed the title ~~feat :Argo listing change~~ feat: Argo listing change Sep 9, 2024

kripanshdevtron approved these changes Sep 9, 2024

View reviewed changes

kartik-579 merged commit d38a408 into develop Sep 9, 2024
4 of 5 checks passed

kartik-579 deleted the argo-listing-change branch September 9, 2024 08:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Argo listing change #5768

feat: Argo listing change #5768

kartik-579 commented Aug 30, 2024 •

edited

Loading

gitguardian bot commented Sep 9, 2024 •

edited

Loading

sonarcloud bot commented Sep 9, 2024

feat: Argo listing change #5768

feat: Argo listing change #5768

Conversation

kartik-579 commented Aug 30, 2024 • edited Loading

Description

Checklist:

Does this PR introduce a user-facing change?

gitguardian bot commented Sep 9, 2024 • edited Loading

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

sonarcloud bot commented Sep 9, 2024

Quality Gate failed

kartik-579 commented Aug 30, 2024 •

edited

Loading

gitguardian bot commented Sep 9, 2024 •

edited

Loading