default PipelineType given (#5668)

devtron-labs · Aug 12, 2024 · fcae94f · fcae94f
1 parent a43cbfa
commit fcae94f
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/pkg/pipeline/BuildPipelineConfigService.go b/pkg/pipeline/BuildPipelineConfigService.go
@@ -285,6 +285,16 @@ func (impl *CiPipelineConfigServiceImpl) patchCiPipelineUpdateSource(baseCiConfi
 		impl.logger.Errorw("error in fetching pipeline", "id", modifiedCiPipeline.Id, "err", err)
 		return nil, err
 	}
+	// updating PipelineType from db if not present in request
+	if modifiedCiPipeline.PipelineType == "" {
+		if CiPipeline.PipelineType(pipeline.PipelineType) != "" {
+			modifiedCiPipeline.PipelineType = CiPipeline.PipelineType(pipeline.PipelineType)
+		} else {
+			// updating default pipelineType if not present in request
+			modifiedCiPipeline.PipelineType = CiPipeline.DefaultPipelineType
+
+		}
+	}
 	if !modifiedCiPipeline.PipelineType.IsValidPipelineType() {
 		impl.logger.Debugw(" Invalid PipelineType", "PipelineType", modifiedCiPipeline.PipelineType)
 		errorMessage := fmt.Sprintf(CiPipeline.PIPELINE_TYPE_IS_NOT_VALID, modifiedCiPipeline.Name)

diff --git a/pkg/pipeline/bean/CiPipeline/CiBuildConfig.go b/pkg/pipeline/bean/CiPipeline/CiBuildConfig.go
@@ -32,6 +32,9 @@ const PIPELINE_TYPE_IS_NOT_VALID = "PipelineType is not valid  for pipeline %s"
 
 type PipelineType string
 
+// default PipelineType
+const DefaultPipelineType = CI_BUILD
+
 const (
 	CI_BUILD  PipelineType = "CI_BUILD"
 	LINKED    PipelineType = "LINKED"