Fix/nodejs requires #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emerson
pushed a commit
that referenced
this pull request
Aug 10, 2017
Add meta support for patch and post
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Priority
High. This fix enables Devour to be brought into a project as a dependency via NPM.
What Changed & Why
NPM/Node does not currently support ES6 style module syntax (
import/export) (ref: nodejs/help#53). When trying to include Devour as a dependancy, I was getting the following error:unexpected token import. To fix this issue, I changed Devour to use the Node.js style module syntax (require/module.exports).