Merge before public release #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed order of values displayed with ?
leucos
reviewed
Apr 22, 2021
| WHITE := $(shell tput -Txterm setaf 7) | ||
| RESET := $(shell tput -Txterm sgr0) | ||
|
|
||
| .PHONY: all build clean |
| ## Build: | ||
| digest: ## Build slowql-digest | ||
| $(GOCMD) mod tidy | ||
| GO111MODULE=on $(GOCMD) build -o $(BUILD_ROOT)digest ./cmd/slowql-digest/ |
There was a problem hiding this comment.
@GO111MODULE ... pour une sortie plus jolie ?
|
|
||
| .PHONY: all build clean | ||
|
|
||
| all: help |
| @@ -0,0 +1,17 @@ | |||
| # Build stage | |||
| FROM devopsworks/golang-upx:1.16 AS builder | |||
| ENV GO111MODULE=on \ | |||
There was a problem hiding this comment.
GO111MODULE plus necessaire
| @@ -0,0 +1,17 @@ | |||
| # Build stage | |||
| FROM devopsworks/golang-upx:1.15 AS builder | |||
| ENV GO111MODULE=on \ | |||
There was a problem hiding this comment.
GO111MODULE plus necessaire
| if sleep > 0 { | ||
| time.Sleep(sleep) | ||
| } | ||
| if noDryRun { |
There was a problem hiding this comment.
would rather move queries <- 42 here (and add a comment about it), and do a if dryRun { continue }
| break | ||
| } | ||
|
|
||
| if firstPass { |
There was a problem hiding this comment.
same remark as before: make first GetNext call before the loop to get rid of if ?
| for idx, part := range parts { | ||
| part = strings.ToLower(part) | ||
|
|
||
| if strings.Contains(part, "query_time:") { |
There was a problem hiding this comment.
may be more elegant with a s/c ?
switch {
case strings.Contains(part, "query_time:"):
....
case strings.Contains(part, "lock_time:"):
...
}
Your call, matter of taste
| // GetNext() Query | ||
| // // GetServerMeta returns informations about the SQL server in usage | ||
| // GetServerMeta() Server | ||
| ParseBlocs(rawBlocs chan []string) |
| type Parser struct { | ||
| db Database | ||
| waitingList chan query.Query | ||
| rawBlocs chan []string |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge develop branch to main before public release
reviews welcomed @devops-works/admins 🙏