-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: excel (plain) #637
Conversation
Hi there, I'm Devicons' Peek Bot and it seems we've ran into a problem (sorry!). Please double check and fix the possible issues below:
I will retry once everything is fixed. If I still fail (sorry!) or there are other erros, the maintainers will investigate. Best of luck, |
Hi there, I'm Devicons' Peek Bot and it seems we've ran into a problem (sorry!). Please double check and fix the possible issues below:
I will retry once everything is fixed. If I still fail (sorry!) or there are other erros, the maintainers will investigate. Best of luck, |
Hi there, I'm Devicons' Peek Bot and it seems we've ran into a problem (sorry!). Please double check and fix the possible issues below:
I will retry once everything is fixed. If I still fail (sorry!) or there are other erros, the maintainers will investigate. Best of luck, |
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the zoomed-in screenshots of the added icons: Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice. The maintainers will now take a look at it and decide whether to merge your PR. Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo. Cheers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if Microsoft Excel should be part of this iconset. I unterstand that you can script within excel (macros/vb) but I'm not sure if it fit's within our guidelines. I would like to open a discussion about it.
I was a bit iffy on this too but apparently, many businesses like small accounting or insurance firms still use Excel as a database of sort. Furthermore, I've heard learning VBA is a huge advantage => VBA runs in Excel so it makes Excel like an "editor" for VBA. |
Well, many developers use Excel, but its purpose is not mainly for developers. I'm not really sure what to do, but I guess we can remove it. There's no harm if we keep it or remove it. 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The icon itself looks good, though. 👍
Let's open this up in |
Co-authored-by: David Leal <halfpacho@gmail.com>
Well, Excel is the reason many mere mortals have done reactive programming, probably without even realizing it: https://branch-blog.qlik.com/what-is-reactive-programming-a1e82cf28575 |
Since there's not a lot of strong support for Excel, I think we can close this PR for now. If we ever need to get the icon (see someone make a good case for it), we can reopen this. |
I'll keep a local copy of the branch |
Taken from #116. Work was done by @Pmz64.