Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alias and remove duplicate files #2001

Closed
wants to merge 7 commits into from

Conversation

weh
Copy link
Contributor

@weh weh commented Nov 13, 2023

@weh weh requested review from a team, ConX, Snailedlt, canaleal and lunatic-fox and removed request for a team November 13, 2023 12:15
@weh
Copy link
Contributor Author

weh commented Nov 13, 2023

Oh, btw this is the PR where i asked myself if we want to have newlines in the svg files, or if we need to remove them.

Copy link
Member

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor modifications need to be made for digitalocean, postcss, and gatsby, but aside from that all is good.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the postcss-original.svg has multiple paths with different fill colors. I think this SVG needs to remain, but the paths need to be unified, and the fill color changed to #dd3a0aff.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated in #2012

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The gatsby-original-wordmark.svg has 2 paths and 2 different fill colors. It unfortunately cant be used for plain-wordmark.

Copy link
Contributor Author

@weh weh Nov 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated in #2006

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thankfully both plain svgs for digital ocean can be removed, but the original svgs have to be updated to have 1 path and fill color. They also have to be scaled to fit the viewbox.

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done in #2005

@lunatic-fox
Copy link
Contributor

Oh, btw this is the PR where i asked myself if we want to have newlines in the svg files, or if we need to remove them.

@weh, the newline character at the end of the file is used, if I'm not mistaken, for compatibility reasons.

@lunatic-fox
Copy link
Contributor

First of all, thank you @weh and @canaleal for quickly make pull requests to fix the found errors. That means a lot! 🚀

@weh, as @canaleal had explained in this comment, we need to make some changes in the icons.

This type of error needs a pull request for each icon, like the one you made for opensuse, because even if we are not modifying an icon, some icon will be deleted eventually. I'm not sure, but since pull request titles together with devicon.json affect what icons will be built I think this is a safer strategy.

@weh
Copy link
Contributor Author

weh commented Nov 15, 2023

sure, i will split the request, and also fix the mentioned svg files when i find time 👍

@Snailedlt
Copy link
Collaborator

Closing this PR since it's being split into multiple PR's

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants