-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Icon: Mithril (Original, Plain) #1938
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work overall. Once you make the two minor adjustments to the json file, the PR will be ready for approval.
Also, you don't have to, but if you feel like it, making a Line Version would be a neat extra touch!
Thanks @canaleal can you tell me what is difference between original and line version? And How should I convert original to line ? |
@Yashh56 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this is the right way @Snailedlt ? |
@Yashh56 Yes that looks correct! ship it! 🚢 |
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Hey @Snailedlt 👋, Please Review the Changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some very minor changes.
Now it all looks good!
Thanks for another great PR @Yashh56 🎉
My First Pull Request Has Been Accepted By Hacktoberfest Team !! Thank You @Snailedlt ,@canaleal And @weh For The Help :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall great work. Just 1 final change and it's ready.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ✔️
Thank you for another great contribution! 💯 🙇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect. looks good to me. Nice work.
@canaleal Great work finding those little details, just remember to resolve suggestions once they are fixed ;) |
PR name matches the format new icon: Icon name (versions separated by a comma). More details here
PR's base is the develop branch.
Your icons are inside a folder as seen here
SVG matches the standards laid out here
A new object is added in the devicon.json file as seen here
This PR closes #1937