Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new icon: Pulsar (original, original-wordmark) #1898

Merged
merged 5 commits into from
Oct 24, 2023
Merged

new icon: Pulsar (original, original-wordmark) #1898

merged 5 commits into from
Oct 24, 2023

Conversation

weh
Copy link
Contributor

@weh weh commented Oct 9, 2023

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes
closes #1810

Link to prove your SVG is correct and up-to-date.

https://pulsar-edit.dev/

@canaleal
Copy link
Member

canaleal commented Oct 9, 2023

Hey @weh, the icons and Json looks good, but pulsar is missing from the SVG file names.

@weh
Copy link
Contributor Author

weh commented Oct 9, 2023

you are right @canaleal, i fixed the filenames :)

canaleal
canaleal reviewed Oct 10, 2023
View reviewed changes
Copy link
Member

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good and follows SVG guidelines. Nice.

Snailedlt
Snailedlt requested changes Oct 21, 2023
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work!
Just suggested some simplification of the svg's. Once the suggestions are accepted it's ready to merge!

icons/pulsar/pulsar-original-wordmark.svg Outdated Show resolved Hide resolved
icons/pulsar/pulsar-original.svg Outdated Show resolved Hide resolved
@weh weh added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 22, 2023
Snailedlt
Snailedlt approved these changes Oct 22, 2023
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✔️
Thank you for another great contribution! 💯 🙇

Snailedlt
Snailedlt requested changes Oct 22, 2023
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, went through your PR a little fast.
It looks like there are some new conflicts in devicon.json could you try and fix them?

weh and others added 4 commits October 23, 2023 11:43
@weh
new icon: Pulsar (original, original-wordmark)
35dc314
@weh
Rename files to match conventions
5812dca
@weh @Snailedlt
Remove height and with, and replace color
508c548 
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
@weh @Snailedlt
Remove height and with, and replace color
bd8f91a 
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
@weh weh force-pushed the feature/1810-add-pulsar-icon branch from c638cc2 to bd8f91a Compare October 23, 2023 09:43
@weh
Copy link
Contributor Author

weh commented Oct 23, 2023

Rebase is done, should be ok now

@weh weh requested a review from Snailedlt October 24, 2023 09:34
@Snailedlt Snailedlt merged commit 9f8f90d into devicons:develop Oct 24, 2023
5 checks passed
@Snailedlt Snailedlt added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Nov 5, 2023
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canaleal canaleal canaleal left review comments

@Snailedlt Snailedlt Snailedlt approved these changes

Assignees
No one assigned
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@weh @canaleal @Snailedlt