-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: Pulsar (original, original-wordmark) #1898
Conversation
Hey @weh, the icons and Json looks good, but pulsar is missing from the SVG file names. |
you are right @canaleal, i fixed the filenames :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good and follows SVG guidelines. Nice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work!
Just suggested some simplification of the svg's. Once the suggestions are accepted it's ready to merge!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ✔️
Thank you for another great contribution! 💯 🙇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, went through your PR a little fast.
It looks like there are some new conflicts in devicon.json
could you try and fix them?
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
c638cc2
to
bd8f91a
Compare
Rebase is done, should be ok now |
Double check these details before you open a PR
develop
branch.devicon.json
file as seen hereThis PR closes
closes #1810
Link to prove your SVG is correct and up-to-date.
https://pulsar-edit.dev/