-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: k6 (Original) #1844
new icon: k6 (Original) #1844
Conversation
355bcea
to
73deb78
Compare
@Panquesito7 Can you review this PR |
@Thomas-Boi Can I get a review on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent PR!
Sorry for the very late review, all of the maintainers have sadly been busy with our private lives most of this year, which is why we are looking for more maintainers (feel free to apply here if you want: #1471)
I did some nitpicking on the icon itself. Once the suggestions are accepted this PR will be accepted :)
case fix case fix Added new icon K6: (Original) case fix case fix requested changes updated
8b36a6e
to
98349a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SVG looks good and so does the JSON.
Double check these details before you open a PR
develop
branch.devicon.json
file as seen hereThis PR closes NONE
#1843
Link to prove your SVG is correct and up-to-date.
https://k6.io