new icon: k6 (Original) #1844
Merged
new icon: k6 (Original) #1844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akhilgkrishnan
force-pushed
the
add-k6-icon
branch
from
355bcea
to
73deb78
Compare
|
@Panquesito7 Can you review this PR |
|
@Thomas-Boi Can I get a review on this? |
Snailedlt
requested changes
Oct 21, 2023
There was a problem hiding this comment.
Excellent PR!
Sorry for the very late review, all of the maintainers have sadly been busy with our private lives most of this year, which is why we are looking for more maintainers (feel free to apply here if you want: #1471)
I did some nitpicking on the icon itself. Once the suggestions are accepted this PR will be accepted :)
Snailedlt
requested review from
a team,
ConX,
Snailedlt,
canaleal and
lunatic-fox
and removed request for
a team
case fix case fix Added new icon K6: (Original) case fix case fix requested changes updated
akhilgkrishnan
force-pushed
the
add-k6-icon
branch
from
8b36a6e
to
98349a0
Compare
Snailedlt
approved these changes
Oct 21, 2023
canaleal
approved these changes
Oct 22, 2023
Snailedlt
added
the
hacktoberfest-accepted
Snailedlt
added
the
feature:icon
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Double check these details before you open a PR
developbranch.devicon.jsonfile as seen hereThis PR closes NONE
#1843
Link to prove your SVG is correct and up-to-date.
https://k6.io