Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: yugabytedb (original, original-wordmark, plain, plain-wordmark) #1825

Merged
merged 8 commits into from
Oct 26, 2023

Conversation

AbdelrahmanDwedar
Copy link
Contributor

@AbdelrahmanDwedar AbdelrahmanDwedar commented Jul 11, 2023

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes NONE

Link to prove your SVG is correct and up-to-date.

I got the SVG from the home page of their official website

AbdelrahmanDwedar and others added 4 commits July 11, 2023 14:34
- Ungroup `original`, `original-wordmark` and `plain-wordmark`
- Unify path of `plain-wordmark` version
@Panquesito7 Panquesito7 added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Jul 21, 2023
devicon.json Outdated Show resolved Hide resolved
Co-authored-by: David Leal <halfpacho@gmail.com>
@AbdelrahmanDwedar
Copy link
Contributor Author

Maybe someone can review these changes and see if there's any issue with them or recommendations?

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✔️
Thank you for the contribution! 🙇

PS: Sorry for the incredibly late review. All of the maintainers have been busy pretty much all year, which is why we are looking for new maintainers. If that's something you'd want to apply to, please check out this discussion: #1436

@Snailedlt Snailedlt requested review from a team, ConX, canaleal and lunatic-fox and removed request for a team October 21, 2023 15:46
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that everything is ok! 👍🏼
Thank you for this contribution! 🚀
image
image

@Snailedlt Snailedlt merged commit 5999e46 into devicons:develop Oct 26, 2023
5 checks passed
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants