Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and use Geckodriver for Linux64 #1675

Merged
merged 3 commits into from
Mar 3, 2023
Merged

Conversation

Panquesito7
Copy link
Member

Things added/changed:

@Panquesito7 Panquesito7 added the devops Use this label for devops related enhancements label Feb 10, 2023
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some questions

.github/workflows/build_icons.yml Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming it's been tested, I think this is safe to approve now 👍
Thanks for the PR @Panquesito7

@lunatic-fox lunatic-fox merged commit 771daeb into develop Mar 3, 2023
@Panquesito7 Panquesito7 deleted the geckodriver_linux64 branch March 3, 2023 16:03
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops Use this label for devops related enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants