Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: scikitlearn (original, plain, line) #1616

Merged
merged 16 commits into from
Mar 17, 2023
Merged

new icon: scikitlearn (original, plain, line) #1616

merged 16 commits into from
Mar 17, 2023

Conversation

ConX
Copy link
Contributor

@ConX ConX commented Jan 6, 2023

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #1032
This was submitted a few days ago(#1605) but was closed to fix the branches.

Link to prove your SVG is correct and up-to-date.

https://scikit-learn.org/stable/about.html#artwork

@ConX ConX changed the title new icon: scikitlearn (original, original-workmark, plain, plain-wordmark, line, line-wordmark) new icon: scikitlearn (original-workmark, plain-wordmark, line-wordmark) Jan 8, 2023
@lunatic-fox lunatic-fox added feature:icon Use this label for pull requests when a new icon is ready to be added to the collection bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Jan 8, 2023
@github-actions

This comment was marked as outdated.

Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there!
I think we can also add tool to tags.
I've optimized your icons using SVGOMG. Hope that's ok! 😁

devicon.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, maybe the icons you added should be the "non-wordmark" versions?

In their repo they call the icon scikit-learn-logo-notext.png. If so, we can add this version as the wordmark version

Though the text might be too small, so I'm fine with not using that version at all.

devicon.json Outdated Show resolved Hide resolved
devicon.json Outdated Show resolved Hide resolved
ConX and others added 4 commits January 9, 2023 15:21
Add "tool" in tags

Co-authored-by: Josélio Júnior <76992016+lunatic-fox@users.noreply.github.com>
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Panquesito7
Panquesito7 previously approved these changes Feb 9, 2023
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks. 🚀

@Panquesito7 Panquesito7 added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Feb 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2023

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

lunatic-fox
lunatic-fox previously approved these changes Feb 9, 2023
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! ✔
Thank you for this contribution! 🚀

devicon.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See panquesito's comment

@Panquesito7 Panquesito7 dismissed their stale review February 9, 2023 22:51

No aliases were provided for the icon.

@github-actions
Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:



Error found regarding filenames:
- This path doesn't exist: '/home/runner/work/devicon/devicon/icons/scikitlearn/scikitlearn-original-wordmark.svg'

Error checking SVGs: no SVGs to check. Might be caused by above issues.

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@github-actions
Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:



Error found regarding filenames:
- This path doesn't exist: '/home/runner/work/devicon/devicon/icons/scikitlearn/scikitlearn-original-wordmark.svg'

Error checking SVGs: no SVGs to check. Might be caused by above issues.

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@Snailedlt Snailedlt changed the title new icon: scikitlearn (original-workmark, plain-wordmark, line-wordmark) new icon: scikitlearn (original, plain, line) Mar 16, 2023
@Snailedlt Snailedlt added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Mar 16, 2023
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Snailedlt
Snailedlt previously approved these changes Mar 16, 2023
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✔️
Thanks for another great contibution! 🚀

Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! ✔
Thank you for this contribution! 🚀

@Snailedlt Snailedlt merged commit 8ce3911 into devicons:develop Mar 17, 2023
@ConX ConX deleted the new-icon-scikitlearn branch March 28, 2023 06:17
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants