Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/fix in devicon.json #1454

Merged
merged 5 commits into from
Oct 14, 2022
Merged

Bugfix/fix in devicon.json #1454

merged 5 commits into from
Oct 14, 2022

Conversation

lunatic-fox
Copy link
Contributor

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened

Features

In devicon.json both handlebars and yarn only have their original and original-wordmark versions, but in their respective objects it's described that they have plain and plain-wordmark versions as well.

Current status:

...
{
    ...
    "versions": {
        "svg": [
            "original",
            "original-wordmark"
        ],
        "font": [
            "plain",
            "plain-wordmark"
        ]
    },
    ...
},
...

Solution:

...
{
    ...
    "versions": {
        "svg": [
            "original",
            "original-wordmark"
        ],
        "font": [
            "original",
            "original-wordmark"
        ]
    },
    ...
    "aliases": [
        {
            "base": "original",
            "alias": "plain"
        },
        {
            "base": "original-wordmark",
            "alias": "plain-wordmark"
        }
    ]
},
...

This PR closes NONE

Notes

@Panquesito7 Panquesito7 added the bug Use this label for pointing out bugs label Oct 13, 2022
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely spotted 🕵️
Thanks for the contribution 🚀
✔️

@Snailedlt Snailedlt merged commit 5ebe851 into devicons:develop Oct 14, 2022
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
* Add Ren'Py

* Update devicon.json

Co-authored-by: David Leal <halfpacho@gmail.com>

* Fix versions and aliases of `handlebars` and `yarn`

Co-authored-by: David Leal <halfpacho@gmail.com>
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
* Add Ren'Py

* Update devicon.json

Co-authored-by: David Leal <halfpacho@gmail.com>

* Fix versions and aliases of `handlebars` and `yarn`

Co-authored-by: David Leal <halfpacho@gmail.com>
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
* Add Ren'Py

* Update devicon.json

Co-authored-by: David Leal <halfpacho@gmail.com>

* Fix versions and aliases of `handlebars` and `yarn`

Co-authored-by: David Leal <halfpacho@gmail.com>
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Use this label for pointing out bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants