-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/fix in devicon.json #1454
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: David Leal <halfpacho@gmail.com>
Panquesito7
approved these changes
Oct 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 🚀
Snailedlt
approved these changes
Oct 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely spotted 🕵️
Thanks for the contribution 🚀
✔️
Snailedlt
pushed a commit
to Snailedlt/devicon
that referenced
this pull request
Oct 15, 2022
* Add Ren'Py * Update devicon.json Co-authored-by: David Leal <halfpacho@gmail.com> * Fix versions and aliases of `handlebars` and `yarn` Co-authored-by: David Leal <halfpacho@gmail.com>
Snailedlt
pushed a commit
to Snailedlt/devicon
that referenced
this pull request
Oct 15, 2022
* Add Ren'Py * Update devicon.json Co-authored-by: David Leal <halfpacho@gmail.com> * Fix versions and aliases of `handlebars` and `yarn` Co-authored-by: David Leal <halfpacho@gmail.com>
Snailedlt
pushed a commit
to Snailedlt/devicon
that referenced
this pull request
Oct 15, 2022
* Add Ren'Py * Update devicon.json Co-authored-by: David Leal <halfpacho@gmail.com> * Fix versions and aliases of `handlebars` and `yarn` Co-authored-by: David Leal <halfpacho@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Double check these details before you open a PR
Features
In devicon.json both
handlebars
andyarn
only have theiroriginal
andoriginal-wordmark
versions, but in their respective objects it's described that they haveplain
andplain-wordmark
versions as well.Current status:
Solution:
This PR closes NONE
Notes