-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: akka (original, original-wordmark, plain, plain-wordmark) #1431
Conversation
Hi! I'm the
Check our CONTRIBUTING guide for more details regarding these errors. Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ozanuslan
nice work 👋
The system doesn't seem to have registered your approval 😄 Could you re-review it? @fmanimashaun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be approved once some with access right review and approve!
This comment was marked as outdated.
This comment was marked as outdated.
Hmm, not sure it looks good when uploaded to IcoMoon. I recommend making a plain versions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but icons used for the font should be mono-colored (see comment below)
What is your opinion on the color of plain versions? There are two 'main' colors of the logo; light blue |
@ozanuslan |
I agree with you. Changing the color in |
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the SVGs as intepreted by Icomoon when we upload the files: Here are the zoomed-in screenshots of the added icons as SVGs: Here are the icons that will be generated by Icomoon: Here are the zoomed-in screenshots of the added icons as icons: Here are the colored versions: The maintainers will now check for:
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done. Thank you for contributing to Devicon! I hope that your icons are accepted into the repository. Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice. Cheers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ✔️
Thanks for contributing! 🙇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Thanks. 🚀
…evicons#1431) * new icon: akka (original, original-wordmark) * fix: font in devicon.json * Apply suggestions from code review * add akka (plain, plain-wordmark) * change akka font color to a lighter blue Co-authored-by: David Leal <halfpacho@gmail.com>
…evicons#1431) * new icon: akka (original, original-wordmark) * fix: font in devicon.json * Apply suggestions from code review * add akka (plain, plain-wordmark) * change akka font color to a lighter blue Co-authored-by: David Leal <halfpacho@gmail.com>
…evicons#1431) * new icon: akka (original, original-wordmark) * fix: font in devicon.json * Apply suggestions from code review * add akka (plain, plain-wordmark) * change akka font color to a lighter blue Co-authored-by: David Leal <halfpacho@gmail.com>
Double check these details before you open a PR
develop
branch.devicon.json
file as seen hereThis PR closes #920
Link to prove your SVG is correct and up-to-date.
@Panquesito7 could you take a look? 😊