new icon: akka (original, original-wordmark, plain, plain-wordmark) #1431

ozanuslan · 2022-10-06T23:05:35Z

Double check these details before you open a PR

PR does not match another non-stale PR currently opened
PR name matches the format new icon: Icon name (versions separated by comma). More details here
PR's base is the develop branch.
Your icons are inside a folder as seen here
SVG matches the standards laid out here
A new object is added in the devicon.json file as seen here

This PR closes #920

Link to prove your SVG is correct and up-to-date.

@Panquesito7 could you take a look? 😊

github-actions · 2022-10-06T23:06:25Z

Hi!

I'm the check-bot and we have some issues with your PR:

Error found in 'devicon.json' for 'akka' entry: 
- missing key: 'font' in 'versions'.

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

fmanimashaun

Hey @ozanuslan

nice work 👋

ozanuslan · 2022-10-07T12:20:34Z

The system doesn't seem to have registered your approval 😄 Could you re-review it? @fmanimashaun

fmanimashaun

@ozanuslan

It should be approved once some with access right review and approve!

devicon.json

Panquesito7 · 2022-10-11T04:14:19Z

Hmm, not sure it looks good when uploaded to IcoMoon. I recommend making a plain versions.
If you need any help, check our Wiki resources or ask on our Discord server. Thanks. 🙂

Snailedlt

Looks good, but icons used for the font should be mono-colored (see comment below)

devicon.json

ozanuslan · 2022-10-11T10:36:57Z

What is your opinion on the color of plain versions? There are two 'main' colors of the logo; light blue #15a9ce, and dark blue #0b5567. I think the light blue versions would look better, but the dark blue was more dominant on the original-wordmark so I picked that one.

Snailedlt · 2022-10-11T11:27:25Z

What is your opinion on the color of plain versions? There are two 'main' colors of the logo; light blue #15a9ce, and dark blue #0b5567. I think the light blue versions would look better, but the dark blue was more dominant on the original-wordmark so I picked that one.

@ozanuslan
I'm leaning more towards the lighter color, both because it looks better and because it's used more on the main website and in the docs, but it's up to you

ozanuslan · 2022-10-11T11:46:16Z

I agree with you. Changing the color in devicon.json to #15a9ce.

github-actions · 2022-10-11T13:08:58Z

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:

Here are the zoomed-in screenshots of the added icons as SVGs:

Here are the icons that will be generated by Icomoon:

Here are the zoomed-in screenshots of the added icons as icons:

Here are the colored versions:

The maintainers will now check for:

The number of Glyphs matches the number of SVGs that were selected.
The icons (second group of pictures) look the same as the SVGs (first group of pictures).
The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Snailedlt

LGTM! ✔️
Thanks for contributing! 🙇

Panquesito7

Great work! Thanks. 🚀

…evicons#1431) * new icon: akka (original, original-wordmark) * fix: font in devicon.json * Apply suggestions from code review * add akka (plain, plain-wordmark) * change akka font color to a lighter blue Co-authored-by: David Leal <halfpacho@gmail.com>

new icon: akka (original, original-wordmark)

199c586

fix: font in devicon.json

2a51035

fmanimashaun approved these changes Oct 7, 2022

View reviewed changes

ozanuslan requested a review from fmanimashaun October 7, 2022 12:20

fmanimashaun previously approved these changes Oct 7, 2022

View reviewed changes

Panquesito7 added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Oct 11, 2022

Panquesito7 reviewed Oct 11, 2022

View reviewed changes

devicon.json Outdated Show resolved Hide resolved

Panquesito7 dismissed fmanimashaun’s stale review via 541aae9 October 11, 2022 04:00

Apply suggestions from code review

541aae9

Panquesito7 added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Oct 11, 2022

This comment was marked as outdated.

Sign in to view

Snailedlt requested changes Oct 11, 2022

View reviewed changes

devicon.json Outdated Show resolved Hide resolved

add akka (plain, plain-wordmark)

11e57d6

ozanuslan changed the title ~~new icon: akka (original, original-wordmark)~~ new icon: akka (original, original-wordmark, plain, plain-wordmark) Oct 11, 2022

ozanuslan requested a review from Snailedlt October 11, 2022 11:17

change akka font color to a lighter blue

25ea2b7

Snailedlt added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Oct 11, 2022

Snailedlt approved these changes Oct 11, 2022

View reviewed changes

Panquesito7 approved these changes Oct 11, 2022

View reviewed changes

Panquesito7 merged commit 35553bc into devicons:develop Oct 11, 2022

Snailedlt mentioned this pull request Feb 5, 2024

Release v2.16.0 #2131

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

new icon: akka (original, original-wordmark, plain, plain-wordmark) #1431

new icon: akka (original, original-wordmark, plain, plain-wordmark) #1431

ozanuslan commented Oct 6, 2022 •

edited

Loading

github-actions bot commented Oct 6, 2022

fmanimashaun left a comment

ozanuslan commented Oct 7, 2022

fmanimashaun left a comment •

edited

Loading

This comment was marked as outdated.

Panquesito7 commented Oct 11, 2022 •

edited

Loading

Snailedlt left a comment

ozanuslan commented Oct 11, 2022 •

edited

Loading

Snailedlt commented Oct 11, 2022

ozanuslan commented Oct 11, 2022

github-actions bot commented Oct 11, 2022

Snailedlt left a comment

Panquesito7 left a comment

new icon: akka (original, original-wordmark, plain, plain-wordmark) #1431

new icon: akka (original, original-wordmark, plain, plain-wordmark) #1431

Conversation

ozanuslan commented Oct 6, 2022 • edited Loading

Double check these details before you open a PR

Link to prove your SVG is correct and up-to-date.

github-actions bot commented Oct 6, 2022

fmanimashaun left a comment

Choose a reason for hiding this comment

ozanuslan commented Oct 7, 2022

fmanimashaun left a comment • edited Loading

Choose a reason for hiding this comment

This comment was marked as outdated.

Panquesito7 commented Oct 11, 2022 • edited Loading

Snailedlt left a comment

Choose a reason for hiding this comment

ozanuslan commented Oct 11, 2022 • edited Loading

Snailedlt commented Oct 11, 2022

ozanuslan commented Oct 11, 2022

github-actions bot commented Oct 11, 2022

Snailedlt left a comment

Choose a reason for hiding this comment

Panquesito7 left a comment

Choose a reason for hiding this comment

ozanuslan commented Oct 6, 2022 •

edited

Loading

fmanimashaun left a comment •

edited

Loading

Panquesito7 commented Oct 11, 2022 •

edited

Loading

ozanuslan commented Oct 11, 2022 •

edited

Loading