-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: liquibase (original, original-wordmark) #1224
Conversation
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the SVGs as intepreted by Icomoon when we upload the files: Here are the zoomed-in screenshots of the added icons as SVGs: Here are the icons that will be generated by Icomoon: Here are the zoomed-in screenshots of the added icons as icons: Here are the colored versions: The maintainers will now check for:
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done. Thank you for contributing to Devicon! I hope that your icons are accepted into the repository. Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice. Cheers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kilian-paquier would you consider adding the new "altnames": []
attribute for liquidbase? https://github.com/devicons/devicon/wiki/Example-of-Submitting-Icons-to-the-Repository
thank you for the contribution!
Hello, Will do today ! Do I need to add aliases as the original svg is also the plain svg ? |
yes, you could add an alias for it following this guide https://github.com/devicons/devicon/wiki/Updating-the-%60devicon.json%60#aliases-and-aliasobj |
Hello @amacado, Thanks for reviewing the PR. The requested change is pushed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* new icon: liquibase (original, original-wordmark) * liquibase| added altnames for liquibase to devicon.json * liquibase| added plain alias for liquibase to devicon.json
* new icon: liquibase (original, original-wordmark) * liquibase| added altnames for liquibase to devicon.json * liquibase| added plain alias for liquibase to devicon.json
* new icon: liquibase (original, original-wordmark) * liquibase| added altnames for liquibase to devicon.json * liquibase| added plain alias for liquibase to devicon.json
Double check these details before you open a PR
Link to prove your SVG is correct and up-to-date.
https://www.liquibase.org/brand (wordmark)
https://www.liquibase.org/wp-content/themes/liquibase/assets/img/cta-icon-org.svg (none-wordmark)
PS : Converted the PNG image into a SVG. I'm also not sure about the aliases, the original svg can be used for the plains version, do i need to add something to the devicon.json ?