Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Discord icon on website #1039

Merged
merged 8 commits into from
Feb 7, 2022
Merged

Conversation

VikashPR
Copy link
Contributor

@VikashPR VikashPR commented Feb 5, 2022

New feature section

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format New Feature: a brief description of feature

This PR fixes

The discord icon in the buttonLink section of the page is updated with latest discord logo considering the bug #907

This new logo style matches the primary colour theme of Devicon #60be86, which matches with other icons within the section.

Present Discord buttonLink design

Screenshot 2022-02-06 at 12 03 34 AM
The logo is outdated.
doesn't match colour scheme of the website.

New Discord buttonLink design

Screenshot 2022-02-06 at 12 04 44 AM

The new logo is latest Discord logo. verify here
The new logo is matched with colour Scheme of the website with #60be86

Notes

This pull request is to resolve issue #907.

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! Sorry about your effort, but we already fixed the Discord logo in #909. Although I like how it matches the color of the GitHub icon. What do you think, @Thomas-Boi?

@Thomas-Boi
Copy link
Member

I agree @Panquesito7. Since the logo has already been fixed, this PR would be redundant. Thank you very much for your work though

@Thomas-Boi Thomas-Boi closed this Feb 6, 2022
@Panquesito7
Copy link
Member

I agree @Panquesito7. Since the logo has already been fixed, this PR would be redundant. Thank you very much for your work though

Hmm, what if we accept this PR? 😅 I like how the logo matches the GitHub icon. What do you think? Thanks. :)

@VikashPR
Copy link
Contributor Author

VikashPR commented Feb 6, 2022

I agree @Panquesito7. Since the logo has already been fixed, this PR would be redundant. Thank you very much for your work though

@Thomas-Boi thankyour. Perhaps you should consider updating the colour scheme of the buttonLinks for Discord. and also closing the bug #907.

@Panquesito7 Panquesito7 reopened this Feb 6, 2022
@Thomas-Boi
Copy link
Member

I agree @Panquesito7. Since the logo has already been fixed, this PR would be redundant. Thank you very much for your work though

Hmm, what if we accept this PR? 😅 I like how the logo matches the GitHub icon. What do you think? Thanks. :)

Do you mean the color or the shape? I'm fine with either one.

@Thomas-Boi
Copy link
Member

Also, if we do accept this PR, perhaps it can be made by rebasing our current develop. This PR contains commits from the vuetify PR, which might duplicate some stuff

@Panquesito7
Copy link
Member

Also, if we do accept this PR, perhaps it can be made by rebasing our current develop. This PR contains commits from the vuetify PR, which might duplicate some stuff

Fixed now. :)

@VikashPR
Copy link
Contributor Author

VikashPR commented Feb 7, 2022

@Thomas-Boi @Panquesito7 Thank you. I'am glad Devicon is accepting my new changes.

@Thomas-Boi Thomas-Boi merged commit b77cc3e into devicons:develop Feb 7, 2022
@Thomas-Boi Thomas-Boi mentioned this pull request Mar 22, 2022
@Snailedlt Snailedlt added feature:icon Use this label for pull requests when a new icon is ready to be added to the collection and removed feature:icon Use this label for pull requests when a new icon is ready to be added to the collection labels Nov 5, 2023
@Snailedlt Snailedlt changed the title update icon: Discord (Latest) update icon on website: Discord (Latest) Nov 5, 2023
@Snailedlt Snailedlt changed the title update icon on website: Discord (Latest) update Discord icon on website Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants