Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade version of typescript to 5.6.2 #52

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Conversation

svor
Copy link
Collaborator

@svor svor commented Sep 19, 2024

What does this PR do?

Upgrades version of typescript npm library to the latest (5.6.2)

What issues does this PR fix or reference?

eclipse-che/che#23082

Is it tested? How?

  • Build the project:
    yarn install
    yarn build
  • Try to generate deworkspace object:
$ node lib/entrypoint.js \
        --devfile-url:https://github.com/che-samples/java-spring-petclinic/tree/main \
        --plugin-registry-url:https://eclipse-che.github.io/che-plugin-registry/main/v3/ \
        --editor-entry:che-incubator/che-code/latest \
        --output-file:/tmp/devworkspace-che-code-latest.yaml \
        --injectDefaultComponent:true \
        --defaultComponentImage:registry.access.redhat.com/ubi8/openjdk-11:latest

Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
@svor svor self-assigned this Sep 19, 2024
Copy link

openshift-ci bot commented Sep 19, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: RomanNikitenko, svor

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@svor svor merged commit bcc6798 into main Sep 20, 2024
2 checks passed
@svor svor deleted the sv-upgrade-typescript branch September 20, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants