Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of version #5

Merged
merged 8 commits into from
Dec 15, 2023
Merged

Conversation

0xE1E10
Copy link
Collaborator

@0xE1E10 0xE1E10 commented Dec 6, 2023

A few changes while we're there:

  • Use check_packages() function for prerequisites. So if a new version of wget is released, we don't try to update it and create churn on all Docker layers below us.
  • Use force option in ln in case LLVM is already installed in base container but at the wrong version.
  • Add ld.lld link.

@0xE1E10
Copy link
Collaborator Author

0xE1E10 commented Dec 7, 2023

Latest commit installs all LLVM packages. Reasoning is that if someone is using this feature instead of the default C++ package, he probably need something special from LLVM. Until someone add options to select specific features (14 of them as of today), it's probably easier to just install all of them.

@jcbhmr
Copy link
Member

jcbhmr commented Dec 7, 2023

Cool! You seem to know what you're doing; I've added you as a collaborator to this repo. You can merge your own PR! 🥳🎉 Feel free to make any other changes you want to -- I'm not an LLVM expert.

@0xE1E10
Copy link
Collaborator Author

0xE1E10 commented Dec 7, 2023

Looks like it fails on Ubuntu Jammy in the test. I've been testing it on the universal image from MS based on Focal. I'll debug that before merging.

@0xE1E10 0xE1E10 merged commit 510c964 into devcontainers-community:main Dec 15, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants