Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: sequential metric count sweep test [Scale-35] #9791

Merged
merged 12 commits into from
Aug 20, 2024

Conversation

highvelcty
Copy link
Contributor

@highvelcty highvelcty commented Aug 2, 2024

PR TITLE

ci: sequential metric count sweep test SCALE-35

Ticket

SCALE-35

Description

Implementation of a sequential metric count sweep test. The changes within do not affect the determined product. They are for testing the determined product and should have minimal bearing on releasing determined.

Test Plan

This new daist was ran on a local deployment.

SeqSweep-sequential_metric_count_sweep

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • [N/A] User-facing API changes have the "User-facing API Change" label
  • [N/A] Release notes have been added as a separate file under docs/release-notes/
  • [N/A] Licenses have been included for new code which was copied and/or modified from any external code

This is an implementation of a sequential metric count sweep test. This is to

  1. Find the limits of how many floating point metrics can be utilized by the end user of determined.
  2. Provide the partial means to test a specification for the maximum metric latency, throughput and volume to be expected by the end user of determined.

@highvelcty highvelcty requested a review from a team as a code owner August 2, 2024 22:28
@cla-bot cla-bot bot added the cla-signed label Aug 2, 2024
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.27%. Comparing base (79ffa52) to head (7567362).
Report is 36 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9791      +/-   ##
==========================================
- Coverage   54.29%   54.27%   -0.03%     
==========================================
  Files        1261     1261              
  Lines      155642   155642              
  Branches     3536     3536              
==========================================
- Hits        84510    84474      -36     
- Misses      70994    71030      +36     
  Partials      138      138              
Flag Coverage Δ
backend 44.90% <ø> (-0.07%) ⬇️
harness 72.61% <ø> (ø)
web 53.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

@mackrorysd mackrorysd force-pushed the SCALE-29-integrate_daist_with_determined_try2 branch from 0cf9178 to e8ea132 Compare August 6, 2024 14:35
@mackrorysd mackrorysd requested review from a team as code owners August 6, 2024 14:35
@mackrorysd mackrorysd requested review from salonig23 and JComins000 and removed request for a team August 6, 2024 14:35
Copy link
Contributor

@JComins000 JComins000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ci changes look fine

Base automatically changed from SCALE-29-integrate_daist_with_determined_try2 to main August 7, 2024 16:06
Copy link

netlify bot commented Aug 7, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 7567362
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66bd2dae72a5c60008c53aa0

@highvelcty highvelcty merged commit 771bbe4 into main Aug 20, 2024
82 of 95 checks passed
@highvelcty highvelcty deleted the SCALE-35-sequential_metric_sweep_test branch August 20, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants