Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pause/Resume run test flake #9592

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Conversation

AmanuelAaron
Copy link
Contributor

@AmanuelAaron AmanuelAaron commented Jun 28, 2024

Ticket

Description

Fix flake in Pause/Resume test

Test Plan

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@AmanuelAaron AmanuelAaron added the to-cherry-pick Pull requests that need to be cherry-picked into the current release label Jun 28, 2024
@cla-bot cla-bot bot added the cla-signed label Jun 28, 2024
Copy link

netlify bot commented Jun 28, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 8581f7a
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/667ef88c9053650008326c43

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.31%. Comparing base (e4724dd) to head (8581f7a).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9592      +/-   ##
==========================================
- Coverage   51.33%   51.31%   -0.03%     
==========================================
  Files        1252     1252              
  Lines      152048   152048              
  Branches     3019     3019              
==========================================
- Hits        78049    78016      -33     
- Misses      73840    73873      +33     
  Partials      159      159              
Flag Coverage Δ
backend 43.94% <ø> (-0.07%) ⬇️
harness 72.80% <ø> (ø)
web 47.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

@AmanuelAaron AmanuelAaron marked this pull request as ready for review June 28, 2024 17:42
Copy link
Contributor

@MikhailKardash MikhailKardash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AmanuelAaron AmanuelAaron merged commit 28cdf6d into main Jun 28, 2024
81 of 94 checks passed
@AmanuelAaron AmanuelAaron deleted the aaron_amanuel/fix-pause-test-flake branch June 28, 2024 19:15
github-actions bot pushed a commit that referenced this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed to-cherry-pick Pull requests that need to be cherry-picked into the current release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants