Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove shared cluster test for circle ci #9579

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

corban-beaird
Copy link
Contributor

@corban-beaird corban-beaird commented Jun 26, 2024

Ticket

Description

Removes the Shared Cluster workflow from the real config while the flake on this test workflow is being resolved.

Test Plan

  • Ensure that CI doesn't include a shared cluster workflow

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

Copy link

netlify bot commented Jun 26, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 1c6de23
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/667c9ea3d1dc700007b02f00

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.84%. Comparing base (d187243) to head (1c6de23).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9579      +/-   ##
==========================================
+ Coverage   49.80%   49.84%   +0.04%     
==========================================
  Files        1247     1247              
  Lines      162287   162287              
  Branches     2888     2887       -1     
==========================================
+ Hits        80820    80900      +80     
+ Misses      81296    81216      -80     
  Partials      171      171              
Flag Coverage Δ
backend 43.94% <ø> (+<0.01%) ⬆️
harness 63.75% <ø> (+0.19%) ⬆️
web 46.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 9 files with indirect coverage changes

@keita-determined keita-determined added the to-cherry-pick Pull requests that need to be cherry-picked into the current release label Jun 26, 2024
@corban-beaird corban-beaird merged commit a5d5616 into main Jun 26, 2024
81 of 94 checks passed
@corban-beaird corban-beaird deleted the corban/disable-shared-cluster-ci-job branch June 26, 2024 23:57
github-actions bot pushed a commit that referenced this pull request Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed to-cherry-pick Pull requests that need to be cherry-picked into the current release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants