Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bumpenvs 8c90e80 #9544

Merged
merged 6 commits into from
Jun 20, 2024
Merged

chore: Bumpenvs 8c90e80 #9544

merged 6 commits into from
Jun 20, 2024

Conversation

MikhailKardash
Copy link
Contributor

@MikhailKardash MikhailKardash commented Jun 20, 2024

Ticket

Description

NGC+ images not showing STDOUT because PYTHONUNBUFFERED was not set in them. This PR introduces that variable.

Test Plan

Run any experiment and add a print statement inside of the for loop. Make sure that the print statement is present in the output logs of that experiment.
CI nightly gpu tests should pass.

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@MikhailKardash MikhailKardash requested review from a team as code owners June 20, 2024 16:49
@cla-bot cla-bot bot added the cla-signed label Jun 20, 2024
@determined-ci determined-ci requested a review from a team June 20, 2024 16:49
@determined-ci determined-ci added the documentation Improvements or additions to documentation label Jun 20, 2024
Copy link

netlify bot commented Jun 20, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit f0755f1
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6674903c8252ba00080304ac

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.88%. Comparing base (ea929fc) to head (f0755f1).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9544      +/-   ##
==========================================
- Coverage   49.90%   49.88%   -0.02%     
==========================================
  Files        1245     1245              
  Lines      161903   161903              
  Branches     2887     2886       -1     
==========================================
- Hits        80795    80764      -31     
- Misses      80937    80968      +31     
  Partials      171      171              
Flag Coverage Δ
backend 43.98% <100.00%> (-0.06%) ⬇️
harness 63.80% <100.00%> (-0.01%) ⬇️
web 46.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
harness/determined/deploy/gcp/constants.py 100.00% <100.00%> (ø)
master/internal/config/provconfig/aws_config.go 11.20% <ø> (ø)
master/internal/config/provconfig/gcp_config.go 26.76% <100.00%> (ø)

... and 7 files with indirect coverage changes

Copy link
Contributor

@azhou-determined azhou-determined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MikhailKardash MikhailKardash merged commit b9ea173 into main Jun 20, 2024
117 of 120 checks passed
@MikhailKardash MikhailKardash deleted the bumpenvs-8c90e80 branch June 20, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants