Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Huggingface Trust Remote Repo #9535

Merged
merged 3 commits into from
Jun 18, 2024
Merged

fix: Huggingface Trust Remote Repo #9535

merged 3 commits into from
Jun 18, 2024

Conversation

MikhailKardash
Copy link
Contributor

Ticket

Description

Huggingface made a breaking change to their datasets repo. Running code locally now requires trust_remote_code=True in any API call that does a load operation. See https://github.com/huggingface/datasets/releases/tag/2.20.0

This PR adds this flag and sets it to true in our TrainerAPI examples.

Test Plan

CI passes, specifically:
test-e2e-gpu-distributed and test-e2e-gpu-nightly

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@cla-bot cla-bot bot added the cla-signed label Jun 17, 2024
Copy link

netlify bot commented Jun 17, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 64f5b5c
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6670be40e940f20008f5cade
😎 Deploy Preview https://deploy-preview-9535--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.26%. Comparing base (6cd7d06) to head (64f5b5c).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9535   +/-   ##
=======================================
  Coverage   49.25%   49.26%           
=======================================
  Files        1241     1241           
  Lines      161384   161384           
  Branches     2867     2868    +1     
=======================================
+ Hits        79491    79500    +9     
+ Misses      81721    81712    -9     
  Partials      172      172           
Flag Coverage Δ
backend 43.83% <ø> (+0.01%) ⬆️
harness 63.81% <ø> (ø)
web 44.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

Copy link
Contributor

@tayritenour tayritenour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MikhailKardash MikhailKardash merged commit 44f446c into main Jun 18, 2024
94 of 105 checks passed
@MikhailKardash MikhailKardash deleted the huggingface_api_fix branch June 18, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants