Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove debug logs that were accidentally committed #9503

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

salonig23
Copy link
Contributor

@salonig23 salonig23 commented Jun 11, 2024

Ticket

Description

Remove debug logs that were accidentally committed in a previous PR

Test Plan

No testing required

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@cla-bot cla-bot bot added the cla-signed label Jun 11, 2024
Copy link

netlify bot commented Jun 11, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit def1774
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6668b83891b5aa00083d9007

@salonig23 salonig23 marked this pull request as ready for review June 11, 2024 20:50
@salonig23 salonig23 requested a review from a team as a code owner June 11, 2024 20:50
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.01%. Comparing base (aa6521b) to head (def1774).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9503      +/-   ##
==========================================
+ Coverage   48.99%   49.01%   +0.01%     
==========================================
  Files        1235     1235              
  Lines      160193   160191       -2     
  Branches     2781     2780       -1     
==========================================
+ Hits        78491    78514      +23     
+ Misses      81527    81502      -25     
  Partials      175      175              
Flag Coverage Δ
backend 43.88% <ø> (+0.04%) ⬆️
harness 63.96% <ø> (ø)
web 44.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
master/internal/api_trials.go 55.65% <ø> (-0.10%) ⬇️

... and 4 files with indirect coverage changes

Copy link
Contributor

@carolinaecalderon carolinaecalderon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@salonig23 salonig23 merged commit e3d01c1 into main Jun 12, 2024
97 of 115 checks passed
@salonig23 salonig23 deleted the remove-random-logs branch June 12, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants