chore: only connect to the database once #9456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9456 +/- ##
=======================================
Coverage 48.57% 48.58%
=======================================
Files 1233 1233
Lines 159168 159158 -10
Branches 2777 2777
=======================================
+ Hits 77312 77322 +10
+ Misses 81682 81662 -20
Partials 174 174
Flags with carried forward coverage won't be shown. Click here to find out more.
|
master/internal/db/postgres.go
Outdated
| func databaseIsFresh() (bool, error) { | ||
| fresh, err := Bun().NewSelect().Table("pg_tables"). | ||
| Where("schemaname = ?", "public"). | ||
| Where("tablename = ?", "gopg_migrations"). |
There was a problem hiding this comment.
Is there a reason why this is being done dynamically? Do we plan to parameterize this query?
There was a problem hiding this comment.
switched to just using tablename = "gopg..."
stoksc
reviewed
May 30, 2024
master/internal/db/setup.go
Outdated
| } | ||
| if !exist["gopg_migrations"] { | ||
| return true, nil | ||
| return db, false, err |
There was a problem hiding this comment.
nit (non-blocking): is there a benefit to returning the db pointer if an error occurs?
There was a problem hiding this comment.
nope that was a mistake, should return nil
master/internal/db/setup.go
Outdated
|
|
||
| exist, err := tablesExist(pgConn, []string{"gopg_migrations", "schema_migrations"}) | ||
| // Setup connects to the database and run any necessary migrations. | ||
| // Takes a list of checks that run after the database is connected on new databases. |
There was a problem hiding this comment.
This is a brilliant solution!
stoksc
reviewed
May 30, 2024
jesse-amano-hpe
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Description
Fix flake here https://app.circleci.com/pipelines/github/determined-ai/determined/56315/workflows/f5c22283-01d5-4543-a12b-8b5d42fff926/jobs/2624963
by connecting the to the database once, where retries correctly happen
Test Plan
ci passes
Checklist
docs/release-notes/.See Release Note for details.