feat: add SearchDetails page (ET-53) #9436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnkim-det
added
the
feature-flagged
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
johnkim-det
requested review from
EmilyBonar
and removed request for
keita-determined
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9436 +/- ##
==========================================
- Coverage 49.07% 43.98% -5.10%
==========================================
Files 1233 910 -323
Lines 159401 119702 -39699
Branches 2778 2779 +1
==========================================
- Hits 78231 52648 -25583
+ Misses 80996 66879 -14117
- Partials 174 175 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
EmilyBonar
approved these changes
May 31, 2024
| } | ||
| }, [basePath, navigate, tab, tabKey]); | ||
|
|
||
| const fetchExperimentDetails = useCallback(async () => { |
There was a problem hiding this comment.
sugg: could be rewritten using useAsync
| <FlatRuns projectId={experiment.projectId} searchId={id} /> | ||
| ), | ||
| key: TabType.Trials, | ||
| label: 'Trials', |
There was a problem hiding this comment.
nit: shouldn't this switch to "Run" terminology instead of Trials?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
ET-53
Description
Test Plan
With Flat Runs feature flag on:
Checklist
docs/release-notes/.See Release Note for details.