Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: skip TestSchedule until flake is fixed #9434

Merged
merged 1 commit into from
May 28, 2024

Conversation

carolinaecalderon
Copy link
Contributor

@carolinaecalderon carolinaecalderon commented May 28, 2024

Ticket

Related to RM-301

Description

Skip TestSchedule in master/internal/rm/kubernetesrm/resource_pool_intg_test.go until the flake is fixed.

Test Plan

N/A

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@cla-bot cla-bot bot added the cla-signed label May 28, 2024
@carolinaecalderon carolinaecalderon marked this pull request as ready for review May 28, 2024 20:11
@carolinaecalderon carolinaecalderon requested a review from a team as a code owner May 28, 2024 20:11
Copy link

netlify bot commented May 28, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit a0478fa
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66563a6c74e01700080ffb5e

Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.60%. Comparing base (9524dd4) to head (a0478fa).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9434      +/-   ##
==========================================
- Coverage   51.24%   48.60%   -2.65%     
==========================================
  Files         746     1233     +487     
  Lines      110663   158973   +48310     
  Branches     2778     2778              
==========================================
+ Hits        56712    77269   +20557     
- Misses      53777    81530   +27753     
  Partials      174      174              
Flag Coverage Δ
backend 42.14% <ø> (+7.87%) ⬆️
harness 64.02% <ø> (ø)
web 44.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 488 files with indirect coverage changes

@carolinaecalderon carolinaecalderon merged commit 9d54093 into main May 28, 2024
87 of 101 checks passed
@carolinaecalderon carolinaecalderon deleted the carolinac/skip-flaky-test branch May 28, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants