test: datagrid tests [INFENG-687] #9400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9400 +/- ##
==========================================
- Coverage 48.62% 43.43% -5.20%
==========================================
Files 1233 909 -324
Lines 159016 119090 -39926
Branches 2777 2778 +1
==========================================
- Hits 77322 51725 -25597
+ Misses 81520 67191 -14329
Partials 174 174
Flags with carried forward coverage won't be shown. Click here to find out more.
|
JComins000
force-pushed
the
jcom/INFENG-687/datagrid-tests
branch
from
0aa2a11
to
975bbb3
Compare
JComins000
force-pushed
the
jcom/INFENG-687/datagrid-tests
branch
from
b67bc12
to
99b7883
Compare
djanicekpach
approved these changes
May 24, 2024
JComins000
force-pushed
the
jcom/INFENG-687/datagrid-tests
branch
from
1b05a75
to
f2011c5
Compare
JComins000
force-pushed
the
jcom/INFENG-687/datagrid-tests
branch
from
4ff2b5a
to
5a080f3
Compare
JComins000
force-pushed
the
jcom/INFENG-687/datagrid-tests
branch
6 times, most recently
from
006203d
to
c9ce6bb
Compare
JComins000
force-pushed
the
jcom/INFENG-687/datagrid-tests
branch
3 times, most recently
from
a564611
to
caa39ab
Compare
JComins000
force-pushed
the
jcom/INFENG-687/datagrid-tests
branch
from
caa39ab
to
b01efb7
Compare
JComins000
commented
May 30, 2024
| sourceType: 'module', | ||
| }, | ||
| plugins: ['import', 'jsdoc', 'react', 'react-hooks', 'sort-keys-fix'], | ||
| root: true, | ||
| ignorePatterns: ['**/src/services/stream/wire.ts', '**/src/e2e/playwright-report/**'], |
There was a problem hiding this comment.
this is a formatting change that came from precommit
JComins000
commented
May 30, 2024
JComins000
commented
May 30, 2024
JComins000
commented
May 30, 2024
| @@ -22,5 +22,5 @@ | |||
| "jsx": "react-jsx", | |||
| "noFallthroughCasesInSwitch": true | |||
| }, | |||
| "include": ["src/**/*", "typings/**/*.ts", "*.ts", "__mocks__/**/*"] | |||
| "include": ["src/**/*", "typings/**/*.ts", "*.ts", "__mocks__/**/*", ".eslintrc.js"] | |||
There was a problem hiding this comment.
precommit was failing without this
JComins000
commented
May 30, 2024
JComins000
commented
May 30, 2024
| } | ||
| } while (await incrementScroll()); | ||
| return false; | ||
| throw new Error(`Column with index ${index} not found.`); |
There was a problem hiding this comment.
this approach worked better than returning false
JComins000
commented
May 30, 2024
| try { | ||
| return await this.scrollColumnIntoView(this.headRow.getColumnDef(s)); | ||
| } catch (e) { | ||
| if ((e as Error).message.indexOf('Column with index') === 0) { |
There was a problem hiding this comment.
not sure if there's a better way
There was a problem hiding this comment.
in the future, given that you're throwing the error here, you could throw an error class that extends from Error
class IndexNotFoundError extends Error {}
class NameNotFoundError extends Error {}
// ...snip
throw new IndexNotFoundError(`Column with index ${index} not found.`);that you then check your caught error is an instance of
} catch(e) {
if(e instanceof IndexNotFoundError) {
throw new NameNotFoundError(`Column with name ${s} not found.`)
}
}There was a problem hiding this comment.
will do! I have a followup coming soon
keita-determined
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
INFENG-687
Description
these are datagrid tests
async log(s: string)on base pagedebug.tsutil. i'm open to using other namesby the way, there is still one more set of tests to write. it's all the pieces of the action menu. I'm gonna try and get the devs to write these parts.
Test Plan
Checklist
docs/release-notes/.See Release Note for details.