chore: don't use a seperate schema for views_and_triggers #9392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9392 +/- ##
==========================================
- Coverage 46.03% 46.01% -0.02%
==========================================
Files 1228 1228
Lines 155889 155874 -15
Branches 2440 2440
==========================================
- Hits 71756 71729 -27
- Misses 83942 83954 +12
Partials 191 191
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mackrorysd
reviewed
May 20, 2024
| @@ -116,10 +116,13 @@ func ensureMigrationUpgrade(tx *pg.Tx) error { | |||
| return nil | |||
| } | |||
|
|
|||
| func (db *PgDB) readDBCodeAndCheckIfDifferent(dbCodeDir string) (map[string]string, bool, error) { | |||
| files, err := os.ReadDir(dbCodeDir) | |||
| func (db *PgDB) readDBCodeAndCheckIfDifferent( | |||
There was a problem hiding this comment.
This is really in need of named return values, or a doc comment or something.
mackrorysd
approved these changes
May 20, 2024
eecsliu
approved these changes
May 20, 2024
Yeah I agree it isn't great. Not sure how to improve it though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Description
Instead of making
views_and_triggersuse a separate schema just require people to manually drop them.Using a separate schema requires us to set the search path requiring extra permissions. Avoid needing more database permissions with this change.
Test Plan
intg passes
Checklist
docs/release-notes/.See Release Note for details.