docs: revert a doc format change to reenable slurm tests #9358
Conversation
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9358 +/- ##
==========================================
- Coverage 45.16% 45.16% -0.01%
==========================================
Files 1230 1230
Lines 154567 154567
Branches 2405 2405
==========================================
- Hits 69817 69809 -8
- Misses 84555 84563 +8
Partials 195 195
Flags with carried forward coverage won't be shown. Click here to find out more. |
.circleci/real_config.yml
Outdated
| branches: | ||
| only: | ||
| - main | ||
| # filters: |
There was a problem hiding this comment.
im not gonna approve until comments are gone
There was a problem hiding this comment.
those are there to just make it easier for the reviewer to see the tests pass.
There was a problem hiding this comment.
I can just link to the CI run once it finishes
There was a problem hiding this comment.
maybe leave it in draft while you're testing. infra robot is pinging me for an automatic review even though the PR isn't quite ready
Ticket
https://hpe-aiatscale.atlassian.net/browse/DET-10292
Description
https://hpe-aiatscale.slack.com/archives/C04C9JXB1C2/p1715354349333909
Test Plan
take out branch protections to let the tests run slurm tets should not fail with image not found
https://app.circleci.com/pipelines/github/determined-ai/determined/55541/workflows/baba4a8f-bd5c-4fd4-9b9e-d99fc065b5c4/jobs/2563937 test ran and passed I'll put back in the branch protection.
Checklist