Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: resource pool intg tests #9357

Merged
merged 1 commit into from
May 13, 2024
Merged

Conversation

carolinaecalderon
Copy link
Contributor

@carolinaecalderon carolinaecalderon commented May 13, 2024

This reverts commit 54fb10a.

Ticket

Description

Reverting this PR because it breaks CI.

Test Plan

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@cla-bot cla-bot bot added the cla-signed label May 13, 2024
@carolinaecalderon carolinaecalderon marked this pull request as ready for review May 13, 2024 16:35
@carolinaecalderon carolinaecalderon requested review from a team as code owners May 13, 2024 16:35
Copy link

netlify bot commented May 13, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 798e2a2
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/664241640da9b10008d69b15

@carolinaecalderon carolinaecalderon enabled auto-merge (squash) May 13, 2024 16:37
Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.14%. Comparing base (54fb10a) to head (798e2a2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9357      +/-   ##
==========================================
- Coverage   46.49%   45.14%   -1.36%     
==========================================
  Files         743     1230     +487     
  Lines      106596   154567   +47971     
  Branches     2405     2405              
==========================================
+ Hits        49567    69786   +20219     
- Misses      56834    84586   +27752     
  Partials      195      195              
Flag Coverage Δ
backend 41.75% <ø> (+7.47%) ⬆️
harness 64.08% <ø> (+<0.01%) ⬆️
web 36.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 488 files with indirect coverage changes

@carolinaecalderon carolinaecalderon merged commit 16a3f3b into main May 13, 2024
82 of 99 checks passed
@carolinaecalderon carolinaecalderon deleted the carolinac/revert-rm-201 branch May 13, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants