-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: edit/delete template from WebUI #9353
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9353 +/- ##
==========================================
- Coverage 45.14% 38.53% -6.62%
==========================================
Files 1230 907 -323
Lines 154572 114905 -39667
Branches 2404 2406 +2
==========================================
- Hits 69788 44283 -25505
+ Misses 84589 70426 -14163
- Partials 195 196 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good to me! I had some questions here and there, but nothing blocking.
Ticket
MD-383
Description
Enable edit and delete function for templates.
Test Plan
With feature flag on, navigate to templates page.
Edit and delete templates should work as expected.
Checklist
docs/release-notes/
.See Release Note for details.