Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: edit/delete template from WebUI #9353

Merged
merged 5 commits into from
May 14, 2024
Merged

Conversation

gt2345
Copy link
Contributor

@gt2345 gt2345 commented May 10, 2024

Ticket

MD-383

Description

Enable edit and delete function for templates.

Test Plan

With feature flag on, navigate to templates page.
Edit and delete templates should work as expected.

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@gt2345 gt2345 added the feature-flagged The changes in this PR are behind a feature flag label May 10, 2024
@gt2345 gt2345 requested a review from a team as a code owner May 10, 2024 19:02
@cla-bot cla-bot bot added the cla-signed label May 10, 2024
@gt2345 gt2345 requested review from hkang1 and removed request for thiagodallacqua-hpe May 10, 2024 19:02
Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 16.52542% with 197 lines in your changes are missing coverage. Please review.

Project coverage is 38.53%. Comparing base (2445d39) to head (01f33ef).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9353      +/-   ##
==========================================
- Coverage   45.14%   38.53%   -6.62%     
==========================================
  Files        1230      907     -323     
  Lines      154572   114905   -39667     
  Branches     2404     2406       +2     
==========================================
- Hits        69788    44283   -25505     
+ Misses      84589    70426   -14163     
- Partials      195      196       +1     
Flag Coverage Δ
harness ?
web 36.01% <16.52%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
webui/react/src/services/apiConfig.ts 72.96% <96.29%> (+0.31%) ⬆️
...eact/src/pages/Templates/TemplatesList.settings.ts 0.00% <0.00%> (ø)
webui/react/src/services/types.ts 0.00% <0.00%> (ø)
webui/react/src/hooks/usePermissions.ts 72.28% <48.14%> (-1.00%) ⬇️
webui/react/src/services/api.ts 0.00% <0.00%> (ø)
.../react/src/pages/Templates/TemplateDeleteModal.tsx 0.00% <0.00%> (ø)
.../react/src/pages/Templates/TemplateCreateModal.tsx 0.00% <0.00%> (ø)
webui/react/src/pages/Templates/TemplatesList.tsx 0.00% <0.00%> (ø)

... and 324 files with indirect coverage changes

Copy link

netlify bot commented May 10, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 01f33ef
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/664254c8a8fdab0008674cb5
😎 Deploy Preview https://deploy-preview-9353--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@hkang1 hkang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good to me! I had some questions here and there, but nothing blocking.

@hkang1 hkang1 assigned gt2345 and unassigned hkang1 May 13, 2024
@gt2345 gt2345 merged commit c7b78fa into main May 14, 2024
83 of 96 checks passed
@gt2345 gt2345 deleted the gt/383-edit/delete-template branch May 14, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed feature-flagged The changes in this PR are behind a feature flag
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants