-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add options in flat run #9341
Conversation
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9341 +/- ##
==========================================
- Coverage 45.14% 38.56% -6.59%
==========================================
Files 1230 906 -324
Lines 154567 114609 -39958
Branches 2404 2405 +1
==========================================
- Hits 69783 44196 -25587
+ Misses 84589 70218 -14371
Partials 195 195
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one comment but otherwise LGTM, probably makes sense to update https://hpe-aiatscale.atlassian.net/browse/ET-259 since you addressed it here?
a75c84d
to
a3a6c82
Compare
i'll update the ticket. i think it should be still |
Ticket
ET-229
Description
Add table settings menu, and removed dead code (infinite scroll is removed permanently)
Test Plan
row height
changes by changing option settings and the settings should persistChecklist
docs/release-notes/
.See Release Note for details.