Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add retries to check-doc-links ci job #9335

Merged
merged 3 commits into from
May 10, 2024
Merged

chore: add retries to check-doc-links ci job #9335

merged 3 commits into from
May 10, 2024

Conversation

hamidzr
Copy link
Contributor

@hamidzr hamidzr commented May 8, 2024

it often run into transient network issues. a simple retry over the whole process works as low lift solution that we can evaluate over time

Ticket

https://hpe-aiatscale.atlassian.net/browse/RM-259

Description

Test Plan

tests pass
https://app.circleci.com/jobs/github/determined-ai/determined/2548113

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@hamidzr hamidzr requested a review from a team as a code owner May 8, 2024 16:34
@hamidzr hamidzr requested a review from djanicekpach May 8, 2024 16:34
@cla-bot cla-bot bot added the cla-signed label May 8, 2024
Copy link

netlify bot commented May 8, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit c2907cc
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/663be393784fc10008816ace

@hamidzr hamidzr changed the title chore: add retries to check-links to hopefully get around transient n… chore: add retries to check-doc-links ci job May 8, 2024
Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.15%. Comparing base (cc82cc9) to head (c2907cc).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9335      +/-   ##
==========================================
+ Coverage   45.13%   45.15%   +0.02%     
==========================================
  Files        1230     1230              
  Lines      154523   154523              
  Branches     2405     2405              
==========================================
+ Hits        69740    69773      +33     
+ Misses      84588    84555      -33     
  Partials      195      195              
Flag Coverage Δ
backend 41.77% <ø> (+0.06%) ⬆️
harness 64.09% <ø> (ø)
web 36.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

Copy link
Contributor

@djanicekpach djanicekpach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@hamidzr hamidzr merged commit 758ffd7 into main May 10, 2024
88 of 101 checks passed
@hamidzr hamidzr deleted the hz-docs-retry branch May 10, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants