test: refactor nav spec to use sidebar pagemodels [INFENG-683] #9326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
JComins000
commented
May 7, 2024
| @@ -7,13 +7,14 @@ import { SignIn } from 'e2e/models/pages/SignIn'; | |||
| import { Workspaces } from 'e2e/models/pages/Workspaces'; | |||
|
|
|||
| test.describe('Navigation', () => { | |||
| const USERNAME = process.env.PW_USER_NAME ?? ''; | |||
There was a problem hiding this comment.
this text was used to click on a button lmao
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9326 +/- ##
==========================================
- Coverage 44.60% 37.94% -6.66%
==========================================
Files 1275 951 -324
Lines 156385 116563 -39822
Branches 2450 2450
==========================================
- Hits 69756 44231 -25525
+ Misses 86389 72092 -14297
Partials 240 240
Flags with carried forward coverage won't be shown. Click here to find out more. |
@loksonarius btw things to look for would be "does it look like I'm replacing these things one-to-one" and "do the tests pass". thanks for looking! |
just gonna merge. circle ci is hitting concurrency limits |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
INFENG-683
Description
refactor to use sidebar pagemodels
Test Plan
Checklist
docs/release-notes/.See Release Note for details.