Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: lower hf trainer accuracy target + improve failure messages #9322

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

eecsliu
Copy link
Contributor

@eecsliu eecsliu commented May 7, 2024

Ticket

Description

test_hf_trainer_api_accuracy failed due to the accuracy target not being met. This PR decreases the accuracy target so that the test is less likely to fail. Additionally, this PR adds some better failure messaging to runs so that future test failures are easier to debug.

Test Plan

No manual testing required. Make sure e2e tests pass.

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@eecsliu eecsliu requested a review from a team as a code owner May 7, 2024 00:30
@cla-bot cla-bot bot added the cla-signed label May 7, 2024
Copy link

netlify bot commented May 7, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit aa95f06
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66625ac90c61510008f90b89

Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.96%. Comparing base (84299a6) to head (aa95f06).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9322   +/-   ##
=======================================
  Coverage   48.96%   48.96%           
=======================================
  Files        1234     1234           
  Lines      159823   159823           
  Branches     2780     2781    +1     
=======================================
+ Hits        78257    78259    +2     
+ Misses      81391    81389    -2     
  Partials      175      175           
Flag Coverage Δ
backend 43.69% <ø> (+<0.01%) ⬆️
harness 63.99% <ø> (ø)
web 44.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

Copy link
Contributor

@MikhailKardash MikhailKardash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eecsliu eecsliu merged commit 96c061b into main Jun 7, 2024
82 of 97 checks passed
@eecsliu eecsliu deleted the improve-e2e-tests branch June 7, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants