Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run e2e-react manually [INFENG-676] #9310

Merged
merged 1 commit into from
May 6, 2024

Conversation

JComins000
Copy link
Contributor

@JComins000 JComins000 commented May 3, 2024

Ticket

INFENG-676

Description

a new workflow for manual e2e

Test Plan

image image

the manual run

when triggered from webhook

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@JComins000 JComins000 requested a review from a team as a code owner May 3, 2024 22:44
@JComins000 JComins000 requested a review from dzhu May 3, 2024 22:44
@cla-bot cla-bot bot added the cla-signed label May 3, 2024
Copy link

netlify bot commented May 3, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 3f13ddf
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6639109cd617d90008c0283d
😎 Deploy Preview https://deploy-preview-9310--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JComins000 JComins000 force-pushed the jcom/INFENG-676/run-e2e-manually branch 4 times, most recently from 986927d to e464f20 Compare May 3, 2024 23:21
@@ -4106,7 +4126,6 @@ workflows:
name: build-react-oss
dev-mode: true
- test-e2e-react:
name: test-e2e-react-oss
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I now have https://www.youtube.com/watch?v=na47wMFfQCo stuck in my head. "I've been through CI in a test with no name."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh actually i think i deleted the wrong line here. good catch

Copy link
Member

@dannysauer dannysauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JComins000 JComins000 force-pushed the jcom/INFENG-676/run-e2e-manually branch from e464f20 to 2fb6cbe Compare May 6, 2024 16:30
@JComins000 JComins000 requested a review from a team as a code owner May 6, 2024 16:30
Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.61%. Comparing base (e90bd0d) to head (3f13ddf).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9310   +/-   ##
=======================================
  Coverage   44.61%   44.61%           
=======================================
  Files        1275     1275           
  Lines      156282   156282           
  Branches     2449     2449           
=======================================
+ Hits        69726    69733    +7     
+ Misses      86316    86309    -7     
  Partials      240      240           
Flag Coverage Δ
backend 41.77% <ø> (+<0.01%) ⬆️
harness 64.10% <ø> (+<0.01%) ⬆️
web 35.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

@JComins000 JComins000 force-pushed the jcom/INFENG-676/run-e2e-manually branch from 2fb6cbe to 3f13ddf Compare May 6, 2024 17:17
@JComins000 JComins000 enabled auto-merge (squash) May 6, 2024 17:34
@JComins000 JComins000 merged commit f9a35d9 into main May 6, 2024
81 of 95 checks passed
@JComins000 JComins000 deleted the jcom/INFENG-676/run-e2e-manually branch May 6, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants