-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: run e2e-react manually [INFENG-676] #9310
Conversation
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
986927d
to
e464f20
Compare
.circleci/real_config.yml
Outdated
@@ -4106,7 +4126,6 @@ workflows: | |||
name: build-react-oss | |||
dev-mode: true | |||
- test-e2e-react: | |||
name: test-e2e-react-oss |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I now have https://www.youtube.com/watch?v=na47wMFfQCo stuck in my head. "I've been through CI in a test with no name."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh actually i think i deleted the wrong line here. good catch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
e464f20
to
2fb6cbe
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9310 +/- ##
=======================================
Coverage 44.61% 44.61%
=======================================
Files 1275 1275
Lines 156282 156282
Branches 2449 2449
=======================================
+ Hits 69726 69733 +7
+ Misses 86316 86309 -7
Partials 240 240
Flags with carried forward coverage won't be shown. Click here to find out more. |
2fb6cbe
to
3f13ddf
Compare
Ticket
INFENG-676
Description
a new workflow for manual e2e
Test Plan
the manual run
when triggered from webhook
Checklist
docs/release-notes/
.See Release Note for details.