Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: log in with the api rather than through the UI for most react tests #9307

Merged
merged 7 commits into from
May 8, 2024

Conversation

djanicekpach
Copy link
Contributor

@djanicekpach djanicekpach commented May 3, 2024

test: log in with the api rather than through the UI for most react tests

Ticket

infeng-671

Description

Previously for all our tests we logged in by navigating to the UI and logging in. It will be faster and have less code to just auto-login through the API and apply the cookie to the browser.

More stuff coming in user management with the next ticket, but this is a self-contained start.

Test Plan

ran manually and CI should pass.

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Copy link

netlify bot commented May 3, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 255fe80
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/663ba1204d4bb90008456d82
😎 Deploy Preview https://deploy-preview-9307--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented May 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 77 lines in your changes are missing coverage. Please review.

Project coverage is 37.90%. Comparing base (dab4946) to head (255fe80).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9307      +/-   ##
==========================================
- Coverage   44.59%   37.90%   -6.69%     
==========================================
  Files        1275      952     -323     
  Lines      156478   116717   -39761     
  Branches     2449     2450       +1     
==========================================
- Hits        69777    44244   -25533     
+ Misses      86461    72232   -14229     
- Partials      240      241       +1     
Flag Coverage Δ
harness ?
web 34.95% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
webui/react/src/e2e/fixtures/dev.fixture.ts 0.00% <0.00%> (ø)
webui/react/src/e2e/fixtures/global-fixtures.ts 0.00% <0.00%> (ø)
webui/react/src/e2e/fixtures/api.auth.fixture.ts 0.00% <0.00%> (ø)

... and 324 files with indirect coverage changes

Copy link
Contributor

@JComins000 JComins000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks pretty good! i guess we didn't change user spec yet. maybe in the future we can use swagger codegen

@djanicekpach djanicekpach force-pushed the djanicek/infeng-671/api-login branch from 990a0d9 to eb4d44c Compare May 8, 2024 15:11
@djanicekpach djanicekpach merged commit cab9ac5 into main May 8, 2024
81 of 96 checks passed
@djanicekpach djanicekpach deleted the djanicek/infeng-671/api-login branch May 8, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants