Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: log health check failures in master logs #9291

Merged
merged 2 commits into from
May 2, 2024

Conversation

NicholasBlaskey
Copy link
Contributor

@NicholasBlaskey NicholasBlaskey commented May 2, 2024

Ticket

Description

Add master logs for failed health checks.

Test Plan

Run devcluster, delete cluster_id table and look to see it is logged

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@NicholasBlaskey NicholasBlaskey requested review from a team as code owners May 2, 2024 15:49
@cla-bot cla-bot bot added the cla-signed label May 2, 2024
Copy link

netlify bot commented May 2, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit ce0022d
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6633b8aec1e10800086eb964

Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.20%. Comparing base (21f76e9) to head (ce0022d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9291      +/-   ##
==========================================
- Coverage   44.59%   44.20%   -0.40%     
==========================================
  Files        1275     1275              
  Lines      156226   156228       +2     
  Branches     2451     2451              
==========================================
- Hits        69674    69060     -614     
- Misses      86312    86928     +616     
  Partials      240      240              
Flag Coverage Δ
backend 41.73% <100.00%> (-0.06%) ⬇️
harness 62.61% <ø> (-1.49%) ⬇️
web 35.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
master/internal/core.go 4.22% <100.00%> (+0.11%) ⬆️
...nal/rm/dispatcherrm/dispatcher_resource_manager.go 18.75% <100.00%> (+0.07%) ⬆️
master/internal/rm/kubernetesrm/pods.go 21.90% <100.00%> (+0.08%) ⬆️

... and 13 files with indirect coverage changes

@NicholasBlaskey NicholasBlaskey enabled auto-merge (squash) May 2, 2024 16:01
@NicholasBlaskey NicholasBlaskey merged commit f1aa92e into main May 2, 2024
81 of 95 checks passed
@NicholasBlaskey NicholasBlaskey deleted the log_health_check_failures branch May 2, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants