Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: stop writing database down migrations [RM-242] #9289

Merged
merged 3 commits into from
May 6, 2024

Conversation

NicholasBlaskey
Copy link
Contributor

@NicholasBlaskey NicholasBlaskey commented May 2, 2024

Ticket

Description

Stop writing down migrations because the time verse value tradeoff isn't there.

Test Plan

CI passes, also create a migration and check that it works incrementally

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@cla-bot cla-bot bot added the cla-signed label May 2, 2024
Copy link

netlify bot commented May 2, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit ddde39b
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6633a0555897d900092a5bb0

Copy link

codecov bot commented May 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 44.59%. Comparing base (21f76e9) to head (ddde39b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9289      +/-   ##
==========================================
- Coverage   44.59%   44.59%   -0.01%     
==========================================
  Files        1275     1275              
  Lines      156226   156229       +3     
  Branches     2451     2451              
==========================================
+ Hits        69674    69675       +1     
- Misses      86312    86314       +2     
  Partials      240      240              
Flag Coverage Δ
backend 41.78% <0.00%> (-0.01%) ⬇️
harness 64.09% <ø> (ø)
web 35.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
master/cmd/determined-master/migrate.go 16.00% <0.00%> (-2.19%) ⬇️

... and 3 files with indirect coverage changes

@NicholasBlaskey NicholasBlaskey marked this pull request as ready for review May 2, 2024 14:22
@NicholasBlaskey NicholasBlaskey requested a review from a team as a code owner May 2, 2024 14:22
@NicholasBlaskey NicholasBlaskey changed the title chore: stop writing database migrations chore: stop writing database down migrations May 2, 2024
@NicholasBlaskey NicholasBlaskey changed the title chore: stop writing database down migrations chore: stop writing database down migrations [RM-242] May 2, 2024
@NicholasBlaskey NicholasBlaskey merged commit ee4f04e into main May 6, 2024
93 of 107 checks passed
@NicholasBlaskey NicholasBlaskey deleted the remove_migrations branch May 6, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants