-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: slots being filled returned out of order on k8s [RM-42] #9276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9276 +/- ##
==========================================
+ Coverage 44.58% 44.60% +0.01%
==========================================
Files 1275 1275
Lines 156214 156226 +12
Branches 2451 2450 -1
==========================================
+ Hits 69655 69679 +24
+ Misses 86319 86307 -12
Partials 240 240
Flags with carried forward coverage won't be shown. Click here to find out more.
|
NicholasBlaskey
changed the title
fix: slots being filled returned out of order on k8s
fix: slots being filled returned out of order on k8s [RM-42]
May 1, 2024
hamidzr
approved these changes
May 2, 2024
NicholasBlaskey
force-pushed
the
fix_jumping_k8s_slots
branch
from
May 2, 2024 13:21
9c5b37f
to
aaadd0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Description
Fix issues where slots were being returned out of order. There are two fixes in this PR
Test Plan
Unit tests cover this pretty well
Manual
Run a devcluster with
and agent
run a experiment, create a user with no access
det -u admin user create test
check agents
det -u test dev curl /api/v1/agents
and see that the contaner is on the same slot id every refreshChecklist
docs/release-notes/
.See Release Note for details.