chore: make command's run startup-hook.sh [RM-159] #9275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9275 +/- ##
==========================================
+ Coverage 44.56% 44.58% +0.01%
==========================================
Files 1275 1275
Lines 156216 156216
Branches 2451 2451
==========================================
+ Hits 69625 69652 +27
+ Misses 86351 86324 -27
Partials 240 240
Flags with carried forward coverage won't be shown. Click here to find out more. |
✅ Deploy Preview for determined-ui canceled.
|
stoksc
approved these changes
May 1, 2024
tara-det-ai
reviewed
May 1, 2024
| **Improvements** | ||
|
|
||
| - Commands: Commands now support automatically running a ``startup-hook.sh`` when one is present in | ||
| the commands context directory. |
There was a problem hiding this comment.
- Commands: Commands now support automatically executing a
startup-hook.shscript if it is present in the command's context directory.
NicholasBlaskey
force-pushed
the
fix_command_entrypoint
branch
from
d48d798
to
c2e9936
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Description
Commands run a startup-hook.sh if specified.
Test Plan
e2e test + manual
Should show
Checklist
docs/release-notes/.See Release Note for details.